public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bruce Korb <bkorb@gnu.org>
To: Daniel Franke <franke.daniel@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [fixincludes, patch] PR30008 - fixes are not applied to files  in non-standard locations (was: fixinclude fnmatch patch)
Date: Sat, 06 Jan 2007 17:25:00 -0000	[thread overview]
Message-ID: <459FDD8F.3090304@gnu.org> (raw)
In-Reply-To: <200701061544.14147.franke.daniel@gmail.com>

Daniel Franke wrote:
> :ADDPATCH fixincludes:
> 
> Some distributions store files that need fixing in non-standard locations. 
> Instead of enumerating those locations, this patch allows for wildcards in 
> the files-section of hacks, e.g.
> 
>     files = "*features.h"
> 
> to match "features.h", "foo/features.h" or "foo/bar/../features.h".
> 
> Bootstrapped and regtested on x86_64-pc-linux-gnu and i686-pc-linux-gnu.
> 
> 
> Most of the attached patch was provided by Bruce Korb [1], I only contributed 
> some minor fixes.
> 
> 2007-01-05  Bruce Korb <bkorb@gnu.org>, 
>             Daniel Franke <franke.daniel@gmail.com>
> 
> 	PR target/30008
> 	* fixincl.tpl: ? (Bruce?)
> 	* fixincl.c (fix_applies, machine_matches): Use fnmatch for pattern matching.
> 	* fixincl.x: Regenerate.
> 	* inclhack.def (glibc_c99_inline_[1234], broken_cabs, broken_nan,
> 	kandr_concat, sco_math): Replace lists of specfic file names by search
> 	patterns.
> 
> 
> The patch does not include the changes to the generated file fixincl.x, anyone 
> applying the patch has to regenerate that file.
> 
> Ok for trunk?

I was just sitting down to do this.  I want to tweak the patch a bit,
so I will do that, sanity check and commit it today.  Thank you.
Regards, Bruce

  reply	other threads:[~2007-01-06 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06 14:44 Daniel Franke
2007-01-06 17:25 ` Bruce Korb [this message]
2007-01-06 18:03 ` Bruce Korb
2007-01-06 19:10   ` Daniel Franke
2007-01-06 20:05     ` Bruce Korb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459FDD8F.3090304@gnu.org \
    --to=bkorb@gnu.org \
    --cc=franke.daniel@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).