From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11645 invoked by alias); 6 Jan 2007 20:05:47 -0000 Received: (qmail 11631 invoked by uid 22791); 6 Jan 2007 20:05:46 -0000 X-Spam-Check-By: sourceware.org Received: from flpvm09.prodigy.net (HELO flpvm09.prodigy.net) (207.115.20.39) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 06 Jan 2007 20:05:41 +0000 X-ORBL: [75.2.132.113] Received: from [10.0.0.2] (adsl-75-2-132-113.dsl.pltn13.sbcglobal.net [75.2.132.113]) by flpvm09.prodigy.net (8.13.8 out.dk.spool/8.13.8) with ESMTP id l06K5HD6015782; Sat, 6 Jan 2007 12:05:17 -0800 Message-ID: <45A00315.4030808@gnu.org> Date: Sat, 06 Jan 2007 20:05:00 -0000 From: Bruce Korb Reply-To: bkorb@gnu.org User-Agent: Thunderbird 1.5.0.8 (X11/20060911) MIME-Version: 1.0 To: Daniel Franke CC: gcc-patches@gcc.gnu.org Subject: Re: [fixincludes, patch] PR30008 - fixes are not applied to files in non-standard locations (was: fixinclude fnmatch patch) References: <200701061544.14147.franke.daniel@gmail.com> <459FE651.8080008@gnu.org> <200701062009.43985.franke.daniel@gmail.com> In-Reply-To: <200701062009.43985.franke.daniel@gmail.com> Content-Type: text/plain; charset=iso-8859-6 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-01/txt/msg00486.txt.bz2 Daniel Franke wrote: > On Saturday 06 January 2007 19:11, Bruce Korb wrote: >> The attached patch is being applied. Thank you, Daniel. Regards, Bruce > > I should have been more verbose about that particular minor fix ... > > Your patch removes these lines: > > - p_fixd->fd_flags |= FD_SKIP_TEST; > - return BOOL_FALSE; > > in machine_matches(). Without them, I observed that no fixes were applied at > all. Thus, my patch added > > + if (have_match == BOOL_FALSE) > + p_fixd->fd_flags |= FD_SKIP_TEST; > > directly after the for-loop to skip any test where "mach" does not match. > > Could you please verify?! Yep. I didn't see that and didn't notice you had made that change Thanks: /* Check for sense inversion then set the "skip test" flag, if needed */ if (p_fixd->fd_flags & FD_MACH_IFNOT) have_match = ! have_match; if (! have_match) p_fixd->fd_flags |= FD_SKIP_TEST; return have_match; }