public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Fix FRV's reg_or_0_operand predicate
@ 2007-01-08  9:44 Nick Clifton
  2007-01-08 11:04 ` Aldy Hernandez
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2007-01-08  9:44 UTC (permalink / raw)
  To: aldyh, aoliva; +Cc: gcc-patches

Hi Aldy, Hi Alex,

  I am going to apply the patch below to fix an "obvious" problem with
  the FRV port.  Namely that the reg_or_0_operand predicate is
  intended to work with CONST_DOUBLES (amongst other rtx types) but
  its definition was not allowing them.

  I think that this patch ought to be applied to the 4.2 and 4.1
  branches as well, but I am not sure if it counts as a regression.
  What do you think ?

Cheers
  Nick

gcc/ChangeLog
2007-01-08  Nick Clifton  <nickc@redhat.com>

	* config/frv/predicates.md (reg_or_0_operand): Accept
	CONST_DOUBLEs.

Index: gcc/config/frv/predicates.md
===================================================================
--- gcc/config/frv/predicates.md	(revision 120570)
+++ gcc/config/frv/predicates.md	(working copy)
@@ -396,7 +396,7 @@
 ;; appropriate type.
 
 (define_predicate "reg_or_0_operand"
-  (match_code "reg,subreg,const_int")
+  (match_code "reg,subreg,const_int,const_double")
 {
   switch (GET_CODE (op))
     {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix FRV's reg_or_0_operand predicate
  2007-01-08  9:44 Fix FRV's reg_or_0_operand predicate Nick Clifton
@ 2007-01-08 11:04 ` Aldy Hernandez
  2007-01-08 15:08   ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: Aldy Hernandez @ 2007-01-08 11:04 UTC (permalink / raw)
  To: Nick Clifton; +Cc: aoliva, gcc-patches

On Mon, Jan 08, 2007 at 09:44:36AM +0000, Nick Clifton wrote:
> Hi Aldy, Hi Alex,
> 
>   I am going to apply the patch below to fix an "obvious" problem with
>   the FRV port.  Namely that the reg_or_0_operand predicate is
>   intended to work with CONST_DOUBLES (amongst other rtx types) but
>   its definition was not allowing them.
> 
>   I think that this patch ought to be applied to the 4.2 and 4.1
>   branches as well, but I am not sure if it counts as a regression.
>   What do you think ?

I'm OK with applying to the branches.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix FRV's reg_or_0_operand predicate
  2007-01-08 11:04 ` Aldy Hernandez
@ 2007-01-08 15:08   ` Nick Clifton
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2007-01-08 15:08 UTC (permalink / raw)
  To: Aldy Hernandez; +Cc: aoliva, gcc-patches

Hi Aldy,

>>   I think that this patch ought to be applied to the 4.2 and 4.1
>>   branches as well, but I am not sure if it counts as a regression.
>>   What do you think ?
> 
> I'm OK with applying to the branches.

Thanks - I have applied the patch to both branches.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-01-08 15:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-08  9:44 Fix FRV's reg_or_0_operand predicate Nick Clifton
2007-01-08 11:04 ` Aldy Hernandez
2007-01-08 15:08   ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).