From: Mark Mitchell <mark@codesourcery.com>
To: Gabriel Dos Reis <gdr@integrable-solutions.net>
Cc: Andrew_Pinski@PlayStation.Sony.Com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, C++] Make Canonical ICE instead of just warn when mismatching
Date: Tue, 23 Jan 2007 03:41:00 -0000 [thread overview]
Message-ID: <45B583EC.9060702@codesourcery.com> (raw)
In-Reply-To: <m3y7oi9e5c.fsf@zeus.integrable-solutions.net>
Gabriel Dos Reis wrote:
> Andrew_Pinski@PlayStation.Sony.Com writes:
>
> | Since Doug mentioned it would ICE without checking enabled
> | (http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00172.html), it seems the
> | right thing to just ICE and then watch out for more fall out. Yes right
> | now we know of a testcase where before this patch we will pass but after
> | we will now ICE but it seems like a good idea to get this ICEing before we
> | get more testcases where we ICE with checking disable. (I posted the
> | reduced testcase for this problem at
> | http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00209.html ).
> |
> | OK? Bootstrapped and tested on i686-linux-gnu with no regressions.
I think we should leave this as is for now, and turn it into a sorry()
or internal_error() before the 4.3 release. For now, it's nice to be
able to work around any failures. You can file a P1 bug against 4.3 to
make that change, if you like.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
prev parent reply other threads:[~2007-01-23 3:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 5:30 Andrew_Pinski
2007-01-04 19:23 ` Mike Stump
2007-01-04 21:00 ` Andrew_Pinski
2007-01-04 22:26 ` Doug Gregor
2007-01-06 8:25 ` Eric Botcazou
2007-01-04 22:36 ` Mike Stump
2007-01-04 23:44 ` Andrew_Pinski
2007-01-04 23:48 ` Daniel Jacobowitz
2007-01-04 23:59 ` Andrew Pinski
2007-01-05 0:03 ` Daniel Jacobowitz
2007-01-05 0:17 ` Andrew_Pinski
2007-01-05 6:44 ` Gabriel Dos Reis
2007-01-05 14:14 ` Doug Gregor
2007-01-05 14:16 ` Richard Kenner
2007-01-05 6:41 ` Gabriel Dos Reis
2007-01-05 2:04 ` Mike Stump
2007-01-05 3:13 ` Brooks Moses
2007-01-05 14:13 ` Doug Gregor
2007-01-05 14:20 ` Richard Guenther
2007-01-05 14:35 ` Doug Gregor
2007-01-05 19:04 ` Mike Stump
2007-01-05 19:12 ` Richard Guenther
2007-01-08 5:14 ` Andrew Pinski
2007-01-05 6:35 ` Gabriel Dos Reis
2007-01-05 6:33 ` Gabriel Dos Reis
2007-01-23 3:41 ` Mark Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B583EC.9060702@codesourcery.com \
--to=mark@codesourcery.com \
--cc=Andrew_Pinski@PlayStation.Sony.Com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).