public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PING] PR 15787 Poor error message with if and blocks
@ 2007-02-10 15:10 Manuel López-Ibáñez
  2007-02-18 11:48 ` [PING^2] " Manuel López-Ibáñez
  0 siblings, 1 reply; 4+ messages in thread
From: Manuel López-Ibáñez @ 2007-02-10 15:10 UTC (permalink / raw)
  To: gcc-patches

http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02533.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PING^2] PR 15787 Poor error message with if and blocks
  2007-02-10 15:10 [PING] PR 15787 Poor error message with if and blocks Manuel López-Ibáñez
@ 2007-02-18 11:48 ` Manuel López-Ibáñez
  2007-03-01 18:15   ` [PING^3] [C++] " Manuel López-Ibáñez
  0 siblings, 1 reply; 4+ messages in thread
From: Manuel López-Ibáñez @ 2007-02-18 11:48 UTC (permalink / raw)
  To: gcc-patches

On 10/02/07, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02533.html


Thanks,

Manuel.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PING^3] [C++] PR 15787 Poor error message with if and blocks
  2007-02-18 11:48 ` [PING^2] " Manuel López-Ibáñez
@ 2007-03-01 18:15   ` Manuel López-Ibáñez
  2007-03-02  4:26     ` Mark Mitchell
  0 siblings, 1 reply; 4+ messages in thread
From: Manuel López-Ibáñez @ 2007-03-01 18:15 UTC (permalink / raw)
  To: gcc-patches; +Cc: Mark Mitchell, Nathan Sidwell

Following discussion with Mark Mitchell.
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02320.html

PING^3: http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02533.html

Thanks,

Manuel.

On 18/02/07, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> On 10/02/07, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> > http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02533.html
>
>
> Thanks,
>
> Manuel.
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PING^3] [C++] PR 15787 Poor error message with if and blocks
  2007-03-01 18:15   ` [PING^3] [C++] " Manuel López-Ibáñez
@ 2007-03-02  4:26     ` Mark Mitchell
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Mitchell @ 2007-03-02  4:26 UTC (permalink / raw)
  To: Manuel López-Ibáñez; +Cc: gcc-patches, Nathan Sidwell

Manuel López-Ibáñez wrote:
> Following discussion with Mark Mitchell.
> http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02320.html
> 
> PING^3: http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02533.html

> -      switch (parser->in_statement)
> +      switch (parser->in_statement & ~IN_IF_STMT)
>  	{
>  	case 0:
>  	  error ("break statement not within loop or switch");
>  	  break;
>  	default:
> -	  gcc_assert ((parser->in_statement & IN_SWITCH_STMT)
> -		      || parser->in_statement == IN_ITERATION_STMT);
> +	  gcc_assert (((parser->in_statement & ~IN_IF_STMT) & IN_SWITCH_STMT)
> +		      || (parser->in_statement & ~IN_IF_STMT) == IN_ITERATION_STMT);

Please create a temporary for parser->in_statement & ~IN_IF_STMT, so
that you don't need to add that & ~IN_IF_STMT in all uses.  The patch is
OK with that change; please update and check in.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-02  4:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-10 15:10 [PING] PR 15787 Poor error message with if and blocks Manuel López-Ibáñez
2007-02-18 11:48 ` [PING^2] " Manuel López-Ibáñez
2007-03-01 18:15   ` [PING^3] [C++] " Manuel López-Ibáñez
2007-03-02  4:26     ` Mark Mitchell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).