From: Xi Ruoyao <xry111@mengyan1223.wang>
To: Bruce Korb <bkorb@gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: committed: [PATCH] fixincludes: simplify handling for access() failure [PR21283, PR80047]
Date: Sun, 14 Nov 2021 02:37:45 +0800 [thread overview]
Message-ID: <45c90206f1d5cc2c73716605dac5d56c920069d8.camel@mengyan1223.wang> (raw)
In-Reply-To: <3059b1e2-022c-713f-4877-8d709484891c@gnu.org>
On Sat, 2021-11-13 at 08:13 -0800, Bruce Korb wrote:
> Perfect.
Committed at r12-5234 with minor format fix.
> On 11/12/21 1:58 PM, Xi Ruoyao wrote:
> > diff --git a/fixincludes/fixincl.c b/fixincludes/fixincl.c
> > index 6dba2f6e830..ee57fbf61b4 100644
> > --- a/fixincludes/fixincl.c
> > +++ b/fixincludes/fixincl.c
> > @@ -1352,11 +1352,10 @@ process (void)
> >
> > if (access (pz_curr_file, R_OK) != 0)
> > {
> > - int erno = errno;
> > - fprintf (stderr, "Cannot access %s from %s\n\terror %d
> > (%s)\n",
> > - pz_curr_file, getcwd ((char *) NULL, MAXPATHLEN),
> > - erno, xstrerror (erno));
> > - return;
> > + /* Some really strange error happened. */
> > + fprintf (stderr, "Cannot access %s: %s\n", pz_curr_file,
> > + xstrerror (errno));
> > + abort();
> > }
> >
> > pz_curr_data = load_file (pz_curr_file);
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2021-11-13 18:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 13:49 [PATCH] fixincludes: don't assume getcwd() can handle NULL argument Xi Ruoyao
2021-11-10 0:02 ` Joseph Myers
2021-11-10 12:22 ` Xi Ruoyao
2021-11-11 0:51 ` Bruce Korb
2021-11-11 13:04 ` Eric Gallager
2021-11-11 16:33 ` [PATCH] fixincludes: fix portability issues about getcwd() [PR21283, PR80047] Xi Ruoyao
2021-11-12 20:59 ` Bruce Korb
2021-11-12 21:08 ` Xi Ruoyao
2021-11-12 21:58 ` [PATCH] fixincludes: simplify handling for access() failure " Xi Ruoyao
2021-11-13 16:13 ` Bruce Korb
2021-11-13 18:37 ` Xi Ruoyao [this message]
2021-11-11 16:40 ` [PATCH] fixincludes: don't assume getcwd() can handle NULL argument Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45c90206f1d5cc2c73716605dac5d56c920069d8.camel@mengyan1223.wang \
--to=xry111@mengyan1223.wang \
--cc=bkorb@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).