[patch] Correct --help=<language> output (PR 31356), add --help=common

[patch] Correct --help=<language> output (PR 31356), add --help=common

[Brooks Moses]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

:ADDPATCH other:

This patch corrects the first line of the "gcc --help=<language>" 
output, as reported in PR 31356.  It also adds a "gcc --help=common" 
variant of the option, which seems like an obvious extension of the 
syntax (given that 90% of the work was already done!).

------------------------------------------------------------
2007-03-25  Brooks Moses  <brooks.moses@codesourcery.com>

	PR other/31356
	* gcc.c (print_specific_help): Fix --help=<language>
	header line.
	(common_handle_option): Support --help=common.

------------------------------------------------------------

Tested with a bootstrap (and running the various "gcc --help=..." 
variants) on i686-pc-linux-gnu.  Ok for trunk?

(I'll do up a documentation patch for the --help=common option, once my 
pending patch for other bits of the --help= documentation is approved.)

- Brooks

[-- Attachment #2: help-language-common.diff --]
[-- Type: text/x-patch, Size: 997 bytes --]

Index: opts.c
===================================================================
--- opts.c	(revision 123170)
+++ opts.c	(working copy)
@@ -893,7 +893,8 @@
 	      descrip_extra = lang_names [i];
 	    }
 	  else
-	    description = _("The following options are supported by, amoung others, the language ");
+	    description = _("The following options are supported by the language ");
+	    descrip_extra = lang_names [i];
 	  break;
 	}
     }
@@ -983,7 +984,8 @@
 	/* Walk along the argument string, parsing each word in turn.
 	   The format is:
 	   arg = [^]{word}[,{arg}]
-	   word = {optimizers|target|warnings|undocumented|params}  */
+	   word = {optimizers|target|warnings|undocumented|
+		   params|common|<language>}  */
 	while (* a != 0)
 	  {
 	    static struct
@@ -1000,6 +1002,7 @@
 	      { "params", CL_PARAMS },
 	      { "joined", CL_JOINED },
 	      { "separate", CL_SEPARATE },
+	      { "common", CL_COMMON },
 	      { NULL, 0 }
 	    };
 	    unsigned int * pflags;

Re: [patch] Correct --help=<language> output (PR 31356), add --help=common

[Brooks Moses]

Brooks Moses wrote:
> :ADDPATCH other:

Incidentally, does anyone know why this (and the other recent patches 
that I put "ADDPATCH" lines on) didn't show up in the patch tracker?

- Brooks

Re: [patch] Correct --help=<language> output (PR 31356), add --help=common

[Mark Mitchell]

Brooks Moses wrote:

> ------------------------------------------------------------
> 2007-03-25  Brooks Moses  <brooks.moses@codesourcery.com>
> 
>     PR other/31356
>     * gcc.c (print_specific_help): Fix --help=<language>
>     header line.
>     (common_handle_option): Support --help=common.
> 
> ------------------------------------------------------------

:REVIEWMAIL: OK

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

[patch] Document --help=common

[Brooks Moses]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Mark Mitchell wrote:
> Brooks Moses wrote:
>> ------------------------------------------------------------
>> 2007-03-25  Brooks Moses  <brooks.moses@codesourcery.com>
>>
>>     PR other/31356
>>     * gcc.c (print_specific_help): Fix --help=<language>
>>     header line.
>>     (common_handle_option): Support --help=common.
>>
>> ------------------------------------------------------------
> 
> :REVIEWMAIL: OK

As promised, here is the followup patch documenting --help=common. 
Tested with "make pdf" and "make info" on i686-pc-linux-gnu.  Ok for trunk?

--------------------------------------------------------------
2007-04-04  Brooks Moses  <brooks.moses@codesourcery.com>

	* doc/invoke.text (--help): Document --help=common.

--------------------------------------------------------------

- Brooks

[-- Attachment #2: help-language-common-doc.diff --]
[-- Type: text/x-patch, Size: 501 bytes --]

Index: invoke.texi
===================================================================
--- invoke.texi	(revision 123497)
+++ invoke.texi	(working copy)
@@ -1128,6 +1128,9 @@
 This will display the options supported for @var{language}, where 
 @var{language} is the name of one of the languages supported in this 
 version of GCC.
+
+@item @samp{common}
+This will display the options that are common to all languages.
 @end table
 
 It is possible to further refine the output of the @option{--help=}

Re: [patch] Document --help=common

[Mark Mitchell]

Brooks Moses wrote:

> --------------------------------------------------------------
> 2007-04-04  Brooks Moses  <brooks.moses@codesourcery.com>
> 
>     * doc/invoke.text (--help): Document --help=common.
> 
> --------------------------------------------------------------

OK, thanks.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713