public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Thomas <paulthomas2@wanadoo.fr>
To: FX Coudert <fxcoudert@gmail.com>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [gfortran,patch] Fix simplification and code generation for REPEAT
Date: Sun, 01 Apr 2007 19:44:00 -0000	[thread overview]
Message-ID: <46100B84.5080506@wanadoo.fr> (raw)
In-Reply-To: <8EB0135F-C663-4266-B010-E5B51629F968@gmail.com>

:REVIEWMAIL:

FX,
>
> Bootstrapped and regtested on i686-linux, OK for mainline ?
OK - just a couple of tiny niggles:

(i) I would have preferred that you use the scalarizer in 
gfc_conv_intrinsic_repeat, as I suggested off-list.  However, what you 
have submitted is perfectly correct - maybe we should add a function for 
generating simple loops, where the counter  is known and the loop body 
is ready to go?

(ii)  simplify.c:2794 -
  /* If NCOPIES isn't a contant, there's nothing we can do.  */

Thanks!

Paul




  reply	other threads:[~2007-04-01 19:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-31 20:02 FX Coudert
2007-04-01 19:44 ` Paul Thomas [this message]
2007-04-03 21:05   ` FX Coudert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46100B84.5080506@wanadoo.fr \
    --to=paulthomas2@wanadoo.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=fxcoudert@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).