From: Mark Mitchell <mark@codesourcery.com>
To: Daniel Berlin <dberlin@dberlin.org>
Cc: "gcc-patches >> GCC Patches" <gcc-patches@gcc.gnu.org>,
Ian Lance Taylor <iant@google.com>
Subject: Re: [PATCH]: Remove staticp langhook
Date: Fri, 06 Apr 2007 21:12:00 -0000 [thread overview]
Message-ID: <4616B7B3.1060206@codesourcery.com> (raw)
In-Reply-To: <4aca3dc20704051428x2372e283nd9c132aa5efb3812@mail.gmail.com>
Daniel Berlin wrote:
> In /
> 2007-04-05 Daniel Berlin <dberlin@dberlin.org>
>
> * tree.c (staticp): No longer use staticp langhook.
> * langhooks.c (lhd_staticp): Removed.
> * langhooks.h (struct lang_hooks): Remove staticp.
> * c-common.c (c_staticp): Remove.
> * c-common.h (c_staticp): Ditto.
> * langhooks-defs.h (lhd_staticp): Ditto.
> (LHD_HOOKS_STATICP): Ditto
>
> In cp/
> 2007-04-05 Daniel Berlin <dberlin@dberlin.org>
>
> * cp-objcp-common.c (cxx_staticp): Remove.
> * cp-objcp-common.h (LANG_HOOKS_STATICP): Remove.
> * cp-tree.h (cxx_staticp):
How pleasant that this works!
Yes, this patch is fine, but please add a comment before:
> + gcc_assert (TREE_CODE (arg) <= LAST_AND_UNUSED_TREE_CODE);
like so:
/* All language-specific nodes should already have been lowered. */
just so we know what that's for. Or, even better, create a
gcc_assert_lowered macro and use that. This isn't a big deal; if you're
not in the mood, just add the comment and check this in.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2007-04-06 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 21:28 Daniel Berlin
2007-04-06 21:12 ` Mark Mitchell [this message]
2007-04-06 23:59 ` Daniel Berlin
2007-04-07 9:23 ` Andreas Schwab
2007-04-07 22:39 ` Daniel Berlin
2007-04-07 23:05 ` Daniel Berlin
2007-04-08 14:42 ` Daniel Berlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4616B7B3.1060206@codesourcery.com \
--to=mark@codesourcery.com \
--cc=dberlin@dberlin.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).