From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9499 invoked by alias); 23 Apr 2007 21:41:44 -0000 Received: (qmail 9491 invoked by uid 22791); 23 Apr 2007 21:41:44 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 23 Apr 2007 22:41:42 +0100 Received: (qmail 3131 invoked from network); 23 Apr 2007 21:41:40 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Apr 2007 21:41:40 -0000 Message-ID: <462D281A.1020204@codesourcery.com> Date: Mon, 23 Apr 2007 21:56:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fix debug information for bitfields References: <20070322132238.GQ4623@sparrowhawk.codesourcery.com> <200703221730.51553.ebotcazou@adacore.com> <20070323134144.GT4623@sparrowhawk.codesourcery.com> In-Reply-To: <20070323134144.GT4623@sparrowhawk.codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-04/txt/msg01535.txt.bz2 Nathan Froyd wrote: > On Thu, Mar 22, 2007 at 05:30:51PM +0100, Eric Botcazou wrote: >>> OK to commit? >> No, you're reverting >> >> 2007-02-12 Eric Botcazou >> >> * dwarf2out.c (round_up_to_align): New static function. >> (field_byte_offset): Use it to round the offset. > > Oops. Sorry about that. Revised patch attached. This patch is OK with a coding-style nit: + else +#endif + { + object_offset_in_bits = bitpos_int; } We're supposed to elide the braces for a one-line dependent statement. No need to retest with that change. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713