From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 02EA93858D3C for ; Tue, 16 Apr 2024 07:00:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02EA93858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02EA93858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713250864; cv=none; b=nbRGWAVdORCRSoblGMAwjNtpurQeK1GMwGuEDPcZ32+qgk8UARUZc1D1l4UmtEYRqSl3VpyOLteZgxSu7lLtU/3UpqbB5cYHtVdknUg1/pKHfQjVE62jsPaj7zlikXowq3bW6HC0OE8J6gxkXHtDOSrZuuHH7RBLU1kGHFE2BI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713250864; c=relaxed/simple; bh=sefOlLvd3WXjdC6k3YMp5vI/anqVBBS1Kr7ET6mQBBI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=QWaTpvrw34kQtYWxAFtxASNULNR4dVWm6ctliFVXGzwIfBUPeJrum3XOZojUP/OogzKB6lV8We07HUzpTJKbHDF9lCNaY7q1LyAM4JAWkdZXxyFarj2RBgAHrF5A94B1biVDg40BScsQN/sr5QurFeE089C2ENVOYlwbqlt5qYc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CE6C437909; Tue, 16 Apr 2024 07:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713250853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D07XHOBlF0qBV+/oYD2O0igMPv41bt9hfq+LmiDEDyE=; b=IK4WZk/KTQS3xza8d06e7pZhhEfAvqz6310R/sHpgntPuGNiFYtOqWqfD5QRozq0p0GT8V J5hcjH64frhgKqahdc4GMVC8pgK74gzj4PUd8reyWLKOqamm1I7IrxcUkOHAIqbtBw/h5l gcM7Aqaz0TrDskP47qRyxZoHI/FgxkA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713250853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D07XHOBlF0qBV+/oYD2O0igMPv41bt9hfq+LmiDEDyE=; b=MZDoL1eM5XFunCdMGZoGEY6nUkbFWZreeBJCS5rDUFUAA+QW+l8hw16gSebmXypL9JTRHt BSylO0/ZOaR2KdCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713250853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D07XHOBlF0qBV+/oYD2O0igMPv41bt9hfq+LmiDEDyE=; b=IK4WZk/KTQS3xza8d06e7pZhhEfAvqz6310R/sHpgntPuGNiFYtOqWqfD5QRozq0p0GT8V J5hcjH64frhgKqahdc4GMVC8pgK74gzj4PUd8reyWLKOqamm1I7IrxcUkOHAIqbtBw/h5l gcM7Aqaz0TrDskP47qRyxZoHI/FgxkA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713250853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D07XHOBlF0qBV+/oYD2O0igMPv41bt9hfq+LmiDEDyE=; b=MZDoL1eM5XFunCdMGZoGEY6nUkbFWZreeBJCS5rDUFUAA+QW+l8hw16gSebmXypL9JTRHt BSylO0/ZOaR2KdCw== Date: Tue, 16 Apr 2024 09:00:53 +0200 (CEST) From: Richard Biener To: Tamar Christina cc: gcc-patches@gcc.gnu.org, nd@arm.com, jlaw@ventanamicro.com Subject: Re: [PATCH]middle-end: skip vectorization check on ilp32 on vect-early-break_124-pr114403.c In-Reply-To: Message-ID: <464qs7q7-2016-47rr-n593-4096ss3qo4qp@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.992]; MIME_GOOD(-0.10)[text/plain]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 16 Apr 2024, Tamar Christina wrote: > Hi all, > > The testcase seems to fail vectorization on -m32 since the access pattern is > determined as too complex. This skips the vectorization check on ilp32 systems > as I couldn't find a better proxy for being able to do strided 64-bit loads and > I suspect it would fail on all 32-bit targets. You could try having Val aligned to 64bits in the structure (likely 32bit targets have it not aligned). > Regtested on x86_64-pc-linux-gnu with -m32 and no issues. > > Ok for master? > > Thanks, > Tamar > > gcc/testsuite/ChangeLog: > > PR tree-optimization/114403 > * gcc.dg/vect/vect-early-break_124-pr114403.c: Skip in ilp32. > > --- > diff --git a/gcc/testsuite/gcc.dg/vect/vect-early-break_124-pr114403.c b/gcc/testsuite/gcc.dg/vect/vect-early-break_124-pr114403.c > index 1751296ab813fe85eaab1f58dc674bac10f6eb7a..db8e00556f116ca81c5a6558ec6ecd3b222ec93d 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-early-break_124-pr114403.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-early-break_124-pr114403.c > @@ -2,11 +2,11 @@ > /* { dg-require-effective-target vect_early_break_hw } */ > /* { dg-require-effective-target vect_long_long } */ > > -/* { dg-final { scan-tree-dump "LOOP VECTORIZED" "vect" } } */ > +/* { dg-final { scan-tree-dump "LOOP VECTORIZED" "vect" { target { ! ilp32 } } } } */ > > #include "tree-vect.h" > > -typedef unsigned long PV; > +typedef unsigned long long PV; > typedef struct _buff_t { > int foo; > PV Val; > > > > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)