From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 3D35D3858D35 for ; Mon, 22 May 2023 12:27:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D35D3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-510d8b0169fso8463820a12.1 for ; Mon, 22 May 2023 05:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684758420; x=1687350420; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fcGbJGWSRqcYNKOC2wkB6NBgLpWnqvO/9RgIg4B7PME=; b=HythdfB+2VOYphuEos9nU50IGfLuqZkA6nl5xTDE4UE/Gbd6eB4ReR1ZbLaqWmTr2r YyNSg+pxJmthL0DKNUCqxgBcOZLgMeFoNzHXByFYniqNF5FDB8QRMclE/doJV9VBthzu ATk+HABVIWdvRzNOS4CN64OG3qjD8lsFRsMbEd0qrtL9lrVEPLASRzmVKM71UVNmiQyo KSZzuKMeU37s0hxFu8pwb+GUeBFc1Cdd0Yb8aWaMwsdu5Ej89nuESZsF71UKYsrHvSNs LLGh7F26I+auDe/iR6+Cv1LgV6D93E+t7ulA9A+GCIlxO3m5ZSxkBX1N5abcK2tyaoc9 lEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684758420; x=1687350420; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fcGbJGWSRqcYNKOC2wkB6NBgLpWnqvO/9RgIg4B7PME=; b=h0wwVFpSATJu7ajLCFnYPDYc7vb/0sk0BbhzsWzxSYC6d46lYL6q4X5WJYUStRwoyx 2tsqy0LgV2cAGOerj8w/RXcIj6HrYUKxn8sr1338hcrTdp1c5WWU+MYj3OB4HxWUEfpQ tPc8GqgkXqb+kLe2qOrwj2wZSaPNrptACYIaxft7oPh5I5dtGQZFbaQEdtMmUnWnExej WIJarnMsyAhRgYi2qJcFHeSmo1L8xKaRClqDs/cVu0ymamLiW4c9DnhuzQKv3vFCpLZv ANgL/Ev9n/MuRY+ys4Sz87utJ4uV+WCDn0qG7lchhYAzHrIKGk5+FQNRsyYZOuq2Hdxm /9Lg== X-Gm-Message-State: AC+VfDxf7u932oTofo+GbSqIWMV4IQur+KZd07tJpVypVXxkSGCPF054 D5wLxa7IBrdej1O2Q27DzUo= X-Google-Smtp-Source: ACHHUZ6YbngyfjOmN13DaMzX2OvYJJRb4nic5kj3ScBOcmW5/fr/GPrzEx8MBiMgsPTDFTITJFiJqg== X-Received: by 2002:a17:907:1609:b0:94f:1c90:cb71 with SMTP id hb9-20020a170907160900b0094f1c90cb71mr11770620ejc.65.1684758419628; Mon, 22 May 2023 05:26:59 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id t11-20020a17090616cb00b0094f1b8901e1sm3044167ejd.68.2023.05.22.05.26.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 05:26:59 -0700 (PDT) Message-ID: <467379a7-460c-90e6-98b2-4b49e69c3d89@gmail.com> Date: Mon, 22 May 2023 14:26:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: rdapp.gcc@gmail.com, "Kito.cheng" , palmer , jeffreyalaw , "richard.sandiford" Subject: Re: [PATCH] RISC-V: Add RVV comparison autovectorization Content-Language: en-US To: "juzhe.zhong@rivai.ai" , gcc-patches References: <20230520045447.3276232-1-juzhe.zhong@rivai.ai> <52c318eb-eab4-6d75-2d85-ea30e00fae81@gmail.com> <34A4D41BE350F8EF+20230522201824794271136@rivai.ai> From: Robin Dapp In-Reply-To: <34A4D41BE350F8EF+20230522201824794271136@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I do refactoring since we are going to have many different > auto-vectorization patterns, for example: cond_add....etc. > > I should make the current framework suitable for all of them to > simplify the future work. That's good in general but can't it wait until the respective changes go in? I don't know how much you intend to change but it will be easier to review as well if we don't change parts now that might be used differently in the future. On top, we won't get everything right with the first shot anyway. Regards Robin