From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 2C0C33AA842F for ; Thu, 17 Nov 2022 14:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C0C33AA842F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id k5so1802954pjo.5 for ; Thu, 17 Nov 2022 06:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gglbxikfqrl1v+Md+URt8Uy2LlWT814x3SEtZZE6acc=; b=ZcH4MhkQiAld7bhqn8GIZneirMSZEwtC6z7qJ6QJo/oXAqYxYtuQtgLQcTBM7kbkW4 CBe1N3nNe81kPknNDzYftc3jFvHJGH9aPmKm3MtxWZ29IydJ4ifBJfRSFxrHVBby/fcp +qkQoBB2LPsMczDKGrXs46weBgCfAoGoCn7FCwtBLu3HYsgzTU6mdnkr70V+5kDy0qj3 zHQyA879TC+sIZRpdtr/tml5ZoiAUD42gH8W7W/MadBa4EjhkT0WHWvnbA2zEzGP8oms /nP200Hkn/JMnqM52zHCWQe+nBJY+5JEPkXn4YAnKfKmhM7aHL1rE9aKkkZCKSqzN+nG xL1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gglbxikfqrl1v+Md+URt8Uy2LlWT814x3SEtZZE6acc=; b=iWxVikHvLcxa192lj5k+kAPN/gck/zt8dgZ8vCdHlI44UhMsQFdgl9pwvXb5OUhMD6 KzAztvIMQYAllcERR3SNwvg3w5kurd53N1ly9xupGDK6RqTlbYxoMw7wn0sv7L0Zt68z PpSjPgQxrW3iPaX74N6coOJT9uq7dtUl2mMyiiSy9U5NKm36PSUlZYywr5V+5u9NfSpo AoRjrYAaVYYK+i+brkSpXMZpY23AmGH/f1a971Rk3u1gsTbrOVn/SU22ZR11fFKRC+6v vyhV8DEgfrpk1K5LkCYSwMSv4bBWBwVo3NuTzp5KVMWOxKsDjrR7H37oOXlKlpBsOI9Y 6BcQ== X-Gm-Message-State: ANoB5pm6VLIeSQWv0jtJGbfXgw8b8vmxTsyyAsrBjRLBRkF1YGcw6vo9 Tb+szj/W0MJG/CvKIP02/48= X-Google-Smtp-Source: AA0mqf5QoOH4Ne5sXpxMPQwhqPm95rNIwOYjpafCKDbn05/T5PyYJRQl4yrwO0zOSVj6eI9gUC3tuA== X-Received: by 2002:a17:903:428c:b0:17f:63a3:cb48 with SMTP id ju12-20020a170903428c00b0017f63a3cb48mr3028616plb.123.1668695674933; Thu, 17 Nov 2022 06:34:34 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id a27-20020aa794bb000000b0056ded8d5918sm1182898pfl.134.2022.11.17.06.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 06:34:34 -0800 (PST) Message-ID: <467686b8-ea88-2ffc-e969-d8a2ed6398df@gmail.com> Date: Thu, 17 Nov 2022 07:34:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] match.pd: rewrite select to branchless expression Content-Language: en-US To: Michael Collison , Prathamesh Kulkarni Cc: gcc-patches@gcc.gnu.org, Richard Biener References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/11/22 06:00, Michael Collison wrote: > Hi Prathamesh, > > It is my understanding that INTEGRAL_TYPE_P applies to the other > integer types you mentioned (chart, short, long). In fact the test > function that motivated this match has a mixture of char and short and > does not restrict matching. What I think Prathamesh is asking is whether or not we want to have tests  with different types.   It's less about correctness I think and more about ensuring that the testsuite covers those tests in case they regress in the future. jeff