public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Caroline Tice <ctice@apple.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	  Geoffrey Keating <geoffk@apple.com>,
	 Eric Christopher <echristo@apple.com>
Subject: Re: Ping 5! [PATCH, revised]: Track uninitialized variables
Date: Sat, 23 Jun 2007 18:54:00 -0000	[thread overview]
Message-ID: <467D63FA.2000902@codesourcery.com> (raw)
In-Reply-To: <E831D0B7-CB6F-4192-8A56-8B9B867B36A7@apple.com>

Caroline Tice wrote:

>>>> I think that giving a link to the original mail in the archives will
>>>> increase the chances of getting a reviewer. And as a rule of thumb,
>>>> anything that makes easier the life of a reviewer will increase the
>>>> chances of getting a patch reviewed.

I've looked at this patch a few times.  To be honest, the reasons I've
never tried to review it is that (a) it's big, and (b) I'm not sure
*why* we want it, (c), the archives and (c) I was secretly hoping Ian
would review it since he'd had some comments before.

Would you please address (b)?  What does having this information in the
debugger allow you to do?  Is it that it helps you debug because you can
tell "uninitialized" from "random weird value"?

Also, what's the memory impact of this patch, given that it makes
VAR_LOCATION bigger?

Why is this target specific?  Do non-GNU debuggers do something bad if
they see DW_OP_GNU_uninit?  If so, do we have to worry about older
versions of GDB?

Does the new dataflow machinery give us any way to get the information
more easily?  Like, can we just ask it about a REG from
one_reg_loc_descriptor, rather than having to pass information around
through multiple functions?

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

  reply	other threads:[~2007-06-23 18:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02  0:03 [PATCH]: " Caroline Tice
2007-05-08 16:25 ` Ping! " Caroline Tice
2007-05-09  0:28 ` Ian Lance Taylor
2007-05-09 16:48   ` Caroline Tice
2007-05-09 17:40     ` Caroline Tice
2007-05-09 18:08     ` Ian Lance Taylor
2007-05-09 18:16       ` Daniel Jacobowitz
2007-05-10  3:29         ` Mark Mitchell
2007-05-11 19:13 ` [PATCH, revised]: " Caroline Tice
2007-05-18 19:48   ` Ping! " Caroline Tice
2007-05-25 21:26     ` Ping2! " Caroline Tice
2007-06-01 16:59       ` Ping3! " Caroline Tice
2007-06-01 17:13         ` Manuel López-Ibáñez
2007-06-01 17:24           ` Caroline Tice
2007-06-08 17:52             ` Ping 4! " Caroline Tice
2007-06-21 17:02               ` Ping 5! " Caroline Tice
2007-06-23 18:54                 ` Mark Mitchell [this message]
2007-07-12 17:24                 ` Ping 6! " Caroline Tice
2007-07-12 20:11                   ` Eric Christopher
2007-07-12 21:04                     ` Caroline Tice
2007-07-11 14:45   ` Ian Lance Taylor
2007-07-16 13:37     ` Richard Guenther
2007-07-16 16:40       ` Caroline Tice
2007-07-16 17:19         ` Caroline Tice
2007-07-16 17:33           ` H.J. Lu
     [not found] <77C94904-DD0A-4A6B-BD47-BEE50A5A262C@apple.com>
2007-06-25 23:07 ` Ping 5! " Caroline Tice
2007-07-03 22:09 Caroline Tice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467D63FA.2000902@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=ctice@apple.com \
    --cc=echristo@apple.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=geoffk@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).