* Make sure symbol version script is writeable
@ 2007-05-07 21:11 Jim Blandy
2007-05-07 22:22 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Jim Blandy @ 2007-05-07 21:11 UTC (permalink / raw)
To: gcc-patches, libstdc++
If the source tree has been made read-only, the libstdc++-v3 build
dies trying to construct src/libstdc++-symbols.ver.
libstdc++-v3/ChangeLog:
2007-05-07 Jim Blandy <jimb@codesourcery.com>
* libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
sure the build tree copy of libstdc++-symbol.ver is writeable.
* libstdc++-v3/src/Makefile.in: Regenerated.
Index: libstdc++-v3/src/Makefile.am
===================================================================
--- libstdc++-v3/src/Makefile.am (revision 124502)
+++ libstdc++-v3/src/Makefile.am (working copy)
@@ -32,6 +32,7 @@
libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
$(port_specific_symbol_files)
cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
+ chmod +w ./libstdc++-symbol.ver
if test "x$(port_specific_symbol_files)" != x; then \
if grep '^# Appended to version file.' \
$(port_specific_symbol_files) /dev/null > /dev/null 2>&1; then \
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Make sure symbol version script is writeable
2007-05-07 21:11 Make sure symbol version script is writeable Jim Blandy
@ 2007-05-07 22:22 ` Andreas Schwab
2007-05-08 1:01 ` Jim Blandy
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2007-05-07 22:22 UTC (permalink / raw)
To: Jim Blandy; +Cc: gcc-patches, libstdc++
Jim Blandy <jimb@codesourcery.com> writes:
> If the source tree has been made read-only, the libstdc++-v3 build
> dies trying to construct src/libstdc++-symbols.ver.
>
> libstdc++-v3/ChangeLog:
> 2007-05-07 Jim Blandy <jimb@codesourcery.com>
>
> * libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
> sure the build tree copy of libstdc++-symbol.ver is writeable.
> * libstdc++-v3/src/Makefile.in: Regenerated.
>
> Index: libstdc++-v3/src/Makefile.am
> ===================================================================
> --- libstdc++-v3/src/Makefile.am (revision 124502)
> +++ libstdc++-v3/src/Makefile.am (working copy)
> @@ -32,6 +32,7 @@
> libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
> $(port_specific_symbol_files)
> cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
> + chmod +w ./libstdc++-symbol.ver
You surely mean `symbols' here?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Make sure symbol version script is writeable
2007-05-07 22:22 ` Andreas Schwab
@ 2007-05-08 1:01 ` Jim Blandy
2007-06-23 20:27 ` Mark Mitchell
0 siblings, 1 reply; 6+ messages in thread
From: Jim Blandy @ 2007-05-08 1:01 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gcc-patches, libstdc++
Andreas Schwab <schwab@suse.de> writes:
> Jim Blandy <jimb@codesourcery.com> writes:
>
>> If the source tree has been made read-only, the libstdc++-v3 build
>> dies trying to construct src/libstdc++-symbols.ver.
>>
>> libstdc++-v3/ChangeLog:
>> 2007-05-07 Jim Blandy <jimb@codesourcery.com>
>>
>> * libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
>> sure the build tree copy of libstdc++-symbol.ver is writeable.
>> * libstdc++-v3/src/Makefile.in: Regenerated.
>>
>> Index: libstdc++-v3/src/Makefile.am
>> ===================================================================
>> --- libstdc++-v3/src/Makefile.am (revision 124502)
>> +++ libstdc++-v3/src/Makefile.am (working copy)
>> @@ -32,6 +32,7 @@
>> libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
>> $(port_specific_symbol_files)
>> cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
>> + chmod +w ./libstdc++-symbol.ver
>
> You surely mean `symbols' here?
Yes, I certainly do. Thanks for the close reading. (This is what I
get for working with three branches at once, none of whose patches
apply cleanly to the others.)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Make sure symbol version script is writeable
2007-05-08 1:01 ` Jim Blandy
@ 2007-06-23 20:27 ` Mark Mitchell
2007-06-25 18:50 ` Jim Blandy
2007-08-07 21:07 ` Jim Blandy
0 siblings, 2 replies; 6+ messages in thread
From: Mark Mitchell @ 2007-06-23 20:27 UTC (permalink / raw)
To: Jim Blandy; +Cc: Andreas Schwab, gcc-patches, libstdc++
Jim Blandy wrote:
> Andreas Schwab <schwab@suse.de> writes:
>> Jim Blandy <jimb@codesourcery.com> writes:
>>
>>> If the source tree has been made read-only, the libstdc++-v3 build
>>> dies trying to construct src/libstdc++-symbols.ver.
>>>
>>> libstdc++-v3/ChangeLog:
>>> 2007-05-07 Jim Blandy <jimb@codesourcery.com>
>>>
>>> * libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
>>> sure the build tree copy of libstdc++-symbol.ver is writeable.
>>> * libstdc++-v3/src/Makefile.in: Regenerated.
>>>
>>> Index: libstdc++-v3/src/Makefile.am
>>> ===================================================================
>>> --- libstdc++-v3/src/Makefile.am (revision 124502)
>>> +++ libstdc++-v3/src/Makefile.am (working copy)
>>> @@ -32,6 +32,7 @@
>>> libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
>>> $(port_specific_symbol_files)
>>> cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
>>> + chmod +w ./libstdc++-symbol.ver
>> You surely mean `symbols' here?
>
> Yes, I certainly do. Thanks for the close reading. (This is what I
> get for working with three branches at once, none of whose patches
> apply cleanly to the others.)
It doesn't look like this patch was ever applied. With the change
Andreas has suggested, this is OK after the lockdown.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Make sure symbol version script is writeable
2007-06-23 20:27 ` Mark Mitchell
@ 2007-06-25 18:50 ` Jim Blandy
2007-08-07 21:07 ` Jim Blandy
1 sibling, 0 replies; 6+ messages in thread
From: Jim Blandy @ 2007-06-25 18:50 UTC (permalink / raw)
To: Mark Mitchell; +Cc: Andreas Schwab, gcc-patches, libstdc++
Mark Mitchell <mark@codesourcery.com> writes:
> It doesn't look like this patch was ever applied. With the change
> Andreas has suggested, this is OK after the lockdown.
Thanks very much. I'll wait for the end of the lockdown.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Make sure symbol version script is writeable
2007-06-23 20:27 ` Mark Mitchell
2007-06-25 18:50 ` Jim Blandy
@ 2007-08-07 21:07 ` Jim Blandy
1 sibling, 0 replies; 6+ messages in thread
From: Jim Blandy @ 2007-08-07 21:07 UTC (permalink / raw)
To: Mark Mitchell; +Cc: Andreas Schwab, gcc-patches, libstdc++
Mark Mitchell <mark@codesourcery.com> writes:
> Jim Blandy wrote:
>> Andreas Schwab <schwab@suse.de> writes:
>>> Jim Blandy <jimb@codesourcery.com> writes:
>>>
>>>> If the source tree has been made read-only, the libstdc++-v3 build
>>>> dies trying to construct src/libstdc++-symbols.ver.
>>>>
>>>> libstdc++-v3/ChangeLog:
>>>> 2007-05-07 Jim Blandy <jimb@codesourcery.com>
>>>>
>>>> * libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
>>>> sure the build tree copy of libstdc++-symbol.ver is writeable.
>>>> * libstdc++-v3/src/Makefile.in: Regenerated.
>>>>
>>>> Index: libstdc++-v3/src/Makefile.am
>>>> ===================================================================
>>>> --- libstdc++-v3/src/Makefile.am (revision 124502)
>>>> +++ libstdc++-v3/src/Makefile.am (working copy)
>>>> @@ -32,6 +32,7 @@
>>>> libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
>>>> $(port_specific_symbol_files)
>>>> cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
>>>> + chmod +w ./libstdc++-symbol.ver
>>> You surely mean `symbols' here?
>>
>> Yes, I certainly do. Thanks for the close reading. (This is what I
>> get for working with three branches at once, none of whose patches
>> apply cleanly to the others.)
>
> It doesn't look like this patch was ever applied. With the change
> Andreas has suggested, this is OK after the lockdown.
I've committed this, revised as below:
libstdc++-v3/ChangeLog:
2007-08-07 Jim Blandy <jimb@codesourcery.com>
* src/Makefile.am (libstdc++-symbol.ver): Make
sure the build tree copy of libstdc++-symbol.ver is writeable.
* src/Makefile.in: Regenerated.
Index: libstdc++-v3/src/Makefile.am
===================================================================
--- libstdc++-v3/src/Makefile.am (revision 127275)
+++ libstdc++-v3/src/Makefile.am (working copy)
@@ -32,6 +32,7 @@
libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
$(port_specific_symbol_files)
cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
+ chmod +w ./libstdc++-symbols.ver
if test "x$(port_specific_symbol_files)" != x; then \
if grep '^# Appended to version file.' \
$(port_specific_symbol_files) /dev/null > /dev/null 2>&1; then \
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-08-07 21:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-07 21:11 Make sure symbol version script is writeable Jim Blandy
2007-05-07 22:22 ` Andreas Schwab
2007-05-08 1:01 ` Jim Blandy
2007-06-23 20:27 ` Mark Mitchell
2007-06-25 18:50 ` Jim Blandy
2007-08-07 21:07 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).