From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15088 invoked by alias); 4 Jul 2007 17:20:32 -0000 Received: (qmail 15080 invoked by uid 22791); 4 Jul 2007 17:20:31 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 04 Jul 2007 17:20:29 +0000 Received: (qmail 15212 invoked from network); 4 Jul 2007 17:20:28 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Jul 2007 17:20:28 -0000 Message-ID: <468BD6CA.8000703@codesourcery.com> Date: Wed, 04 Jul 2007 17:51:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.4 (Windows/20070604) MIME-Version: 1.0 To: David Daney CC: Paolo Bonzini , gcc-patches@gcc.gnu.org Subject: Re: [Patch] 1/3 Add new builtin __builtin_flush_icache(). References: <468734D3.3020908@avtrex.com> <46875F54.8070905@gnu.org> <4687F6C1.6050906@avtrex.com> <46888752.2040207@gnu.org> <468ADFB4.4060400@codesourcery.com> <468BCF25.40807@avtrex.com> In-Reply-To: <468BCF25.40807@avtrex.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg00386.txt.bz2 David Daney wrote: > void > __clear_cache (char *beg, char *end) > { > if (__builtin_clear_cache_inline_p()) > __builtin___clear_cache (beg, end); > else > { > #ifdef CLEAR_INSN_CACHE > CLEAR_INSN_CACHE (beg, end); > #endif /* CLEAR_INSN_CACHE */ > } > } > > No changes to any existing CLEAR_INSN_CACHE definitions are needed. > There is a new target hook that determines the value of > __builtin_clear_cache_inline_p(). I think that's a little bit overly complicated. Since the target has to do something anyhow, to indicate that we should call the builtin here, we might as well just have the target define CLEAR_INSN_CACHE that way. My two cents, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713