public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Paolo Bonzini <bonzini@gnu.org>,
	Andrew Pinski <pinskia@gmail.com>,
	  gcc-patches@gcc.gnu.org, Mark Mitchell <mark@codesourcery.com>
Subject: Re: PR/32004, tree-ssa caused in/out asm constraints to often need  reloads
Date: Mon, 09 Jul 2007 12:32:00 -0000	[thread overview]
Message-ID: <469228F7.6020601@gnu.org> (raw)
In-Reply-To: <200707090748.59581.ebotcazou@adacore.com>

Eric Botcazou wrote:
>> I will look at it and may eventually revert it, but I'll note that this
>> "brand new pass" just adds a few (set (reg) (reg)).
> 
> Please remove it from the 4.1 branch, you didn't get approval to put it there 
> and you apparently didn't even test it there, causing the first regressions 
> in months on the branch.

Actually it is fixed by this trivial patch.  Ok for 4.2/4.1?

Paolo

Index: ../base-gcc-src/gcc/function.c
===================================================================
--- ../base-gcc-src/gcc/function.c      (revision 126418)
+++ ../base-gcc-src/gcc/function.c      (working copy)
@@ -5713,7 +5713,7 @@ rest_of_match_asm_constraints (void)
      }

    update_life_info_in_dirty_blocks (UPDATE_LIFE_GLOBAL_RM_NOTES,
-                                    PROP_DEATH_NOTES);
+                                    PROP_DEATH_NOTES | PROP_REG_INFO);
    return 0;
  }


  parent reply	other threads:[~2007-07-09 12:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 10:54 Paolo Bonzini
     [not found] ` <84fc9c000707050401h46157b0fye4b32c3e6b1c8063@mail.gmail.com>
2007-07-05 11:48   ` Paolo Bonzini
2007-07-05 18:34 ` Mark Mitchell
2007-07-05 19:39   ` Paolo Bonzini
2007-07-05 20:24     ` Mark Mitchell
2007-07-05 20:15   ` Paolo Bonzini
2007-07-07 16:29 ` Eric Botcazou
2007-07-07 18:24   ` Andrew Pinski
2007-07-07 18:30     ` Eric Botcazou
2007-07-09  2:23       ` Paolo Bonzini
2007-07-09  6:52         ` Eric Botcazou
2007-07-09 12:09           ` Paolo Bonzini
2007-07-09 12:32           ` Paolo Bonzini [this message]
2007-07-09 12:40             ` Richard Guenther
2007-07-09 13:01             ` Eric Botcazou
2007-07-09 13:01               ` Richard Guenther
2007-07-09 13:36                 ` Eric Botcazou
2007-07-09 13:12               ` Paolo Bonzini
2007-07-09 13:23                 ` Andrew Pinski
2007-07-09 13:45                   ` Eric Botcazou
2007-07-09 15:33                   ` Paolo Bonzini
2007-07-09 17:25                     ` Eric Botcazou
2007-07-09 14:00                 ` Eric Botcazou
2007-07-13  9:48       ` Paolo Bonzini
2007-07-13 13:42         ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469228F7.6020601@gnu.org \
    --to=bonzini@gnu.org \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).