From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15886 invoked by alias); 9 Jul 2007 12:24:31 -0000 Received: (qmail 15876 invoked by uid 22791); 9 Jul 2007 12:24:30 -0000 X-Spam-Check-By: sourceware.org Received: from ag-out-0708.google.com (HELO ag-out-0708.google.com) (72.14.246.243) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jul 2007 12:24:27 +0000 Received: by ag-out-0708.google.com with SMTP id 33so586814agc for ; Mon, 09 Jul 2007 05:24:25 -0700 (PDT) Received: by 10.90.73.7 with SMTP id v7mr1535372aga.1183983865555; Mon, 09 Jul 2007 05:24:25 -0700 (PDT) Received: from scientist.lan ( [65.94.94.105]) by mx.google.com with ESMTP id 24sm7693529nzn.2007.07.09.05.24.23 (version=SSLv3 cipher=RC4-MD5); Mon, 09 Jul 2007 05:24:24 -0700 (PDT) Message-ID: <469228F7.6020601@gnu.org> Date: Mon, 09 Jul 2007 12:32:00 -0000 From: Paolo Bonzini User-Agent: Thunderbird 2.0.0.4 (Macintosh/20070604) MIME-Version: 1.0 To: Eric Botcazou CC: Paolo Bonzini , Andrew Pinski , gcc-patches@gcc.gnu.org, Mark Mitchell Subject: Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads References: <468CC82F.2060702@lu.unisi.ch> <200707072023.25902.ebotcazou@adacore.com> <4691965D.703@gnu.org> <200707090748.59581.ebotcazou@adacore.com> In-Reply-To: <200707090748.59581.ebotcazou@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg00781.txt.bz2 Eric Botcazou wrote: >> I will look at it and may eventually revert it, but I'll note that this >> "brand new pass" just adds a few (set (reg) (reg)). > > Please remove it from the 4.1 branch, you didn't get approval to put it there > and you apparently didn't even test it there, causing the first regressions > in months on the branch. Actually it is fixed by this trivial patch. Ok for 4.2/4.1? Paolo Index: ../base-gcc-src/gcc/function.c =================================================================== --- ../base-gcc-src/gcc/function.c (revision 126418) +++ ../base-gcc-src/gcc/function.c (working copy) @@ -5713,7 +5713,7 @@ rest_of_match_asm_constraints (void) } update_life_info_in_dirty_blocks (UPDATE_LIFE_GLOBAL_RM_NOTES, - PROP_DEATH_NOTES); + PROP_DEATH_NOTES | PROP_REG_INFO); return 0; }