From: Paolo Bonzini <bonzini@gnu.org>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>,
gcc-patches@gcc.gnu.org, Mark Mitchell <mark@codesourcery.com>
Subject: Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads
Date: Mon, 09 Jul 2007 15:33:00 -0000 [thread overview]
Message-ID: <46925495.9090305@gnu.org> (raw)
In-Reply-To: <de8d50360707090612h284cae7ame1d057c57844192d@mail.gmail.com>
> Just a latent bug showed up because the trunk and the branches
> have large differences in the dataflow.
I don't need any kind of defense because I *did* make a mistake in the
testing and because this is *not* a latent bug. The backport was not as
obvious as I had thought, so in retrospect what I should have done would
have been to first submit a patch for 4.3 only, and then a patch for
4.2/4.1.
I remember I had made the same mistake (not looking at the wrong logs,
O:-) rather assuming that the same fix applied to two wildly different
codebases) with a performance PR affecting 4.0 and 3.4 (I don't remember
the PR number); in that case Eric also had suggested reverting on 3.4
and I did that exactly.
In this case however this is a much worse bug (it is P1 for a reason,
even if the testcase was not reported by a user), so I'm committing the
additional fix which has been approved by Richard.
Paolo
next prev parent reply other threads:[~2007-07-09 15:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 10:54 Paolo Bonzini
[not found] ` <84fc9c000707050401h46157b0fye4b32c3e6b1c8063@mail.gmail.com>
2007-07-05 11:48 ` Paolo Bonzini
2007-07-05 18:34 ` Mark Mitchell
2007-07-05 19:39 ` Paolo Bonzini
2007-07-05 20:24 ` Mark Mitchell
2007-07-05 20:15 ` Paolo Bonzini
2007-07-07 16:29 ` Eric Botcazou
2007-07-07 18:24 ` Andrew Pinski
2007-07-07 18:30 ` Eric Botcazou
2007-07-09 2:23 ` Paolo Bonzini
2007-07-09 6:52 ` Eric Botcazou
2007-07-09 12:09 ` Paolo Bonzini
2007-07-09 12:32 ` Paolo Bonzini
2007-07-09 12:40 ` Richard Guenther
2007-07-09 13:01 ` Eric Botcazou
2007-07-09 13:01 ` Richard Guenther
2007-07-09 13:36 ` Eric Botcazou
2007-07-09 13:12 ` Paolo Bonzini
2007-07-09 13:23 ` Andrew Pinski
2007-07-09 13:45 ` Eric Botcazou
2007-07-09 15:33 ` Paolo Bonzini [this message]
2007-07-09 17:25 ` Eric Botcazou
2007-07-09 14:00 ` Eric Botcazou
2007-07-13 9:48 ` Paolo Bonzini
2007-07-13 13:42 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46925495.9090305@gnu.org \
--to=bonzini@gnu.org \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark@codesourcery.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).