* [PATCH] bootstrap: Fix bootstrap with --disable-plugin [PR104176]
@ 2022-01-22 11:59 Jakub Jelinek
2022-01-22 17:38 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2022-01-22 11:59 UTC (permalink / raw)
To: Richard Biener, Jeff Law; +Cc: gcc-patches
Hi!
With --disable-plugin, bootstrap fails on x86_64-linux or probably
all other targets with:
../../gcc/opts-global.cc: In function ‘void handle_common_deferred_options()’:
../../gcc/opts-global.cc:420:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag]
420 | error ("plugin support is disabled; configure with --enable-plugin");
| ^~~~~~~~~~~~~~~
../../gcc/opts-global.cc:428:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag]
428 | error ("plugin support is disabled; configure with --enable-plugin");
| ^~~~~~~~~~~~~~~
The following patch fixes that, bootstrapped on x86_64-linux with
--disable-plugin --enable-languages=c,c++
without the patch (where it failed as above) and with it (where it
succeeded), ok for trunk?
2022-01-22 Jakub Jelinek <jakub@redhat.com>
PR other/104176
* opts-global.cc (handle_common_deferred_options): Quote
--enable-plugin in diagnostics to avoid -Werror=format-diag.
--- gcc/opts-global.cc.jj 2022-01-18 11:58:59.741979785 +0100
+++ gcc/opts-global.cc 2022-01-22 02:18:39.116047945 +0100
@@ -417,7 +417,8 @@ handle_common_deferred_options (void)
#ifdef ENABLE_PLUGIN
add_new_plugin (opt->arg);
#else
- error ("plugin support is disabled; configure with --enable-plugin");
+ error ("plugin support is disabled; configure with "
+ "%<--enable-plugin%>");
#endif
break;
@@ -425,7 +426,8 @@ handle_common_deferred_options (void)
#ifdef ENABLE_PLUGIN
parse_plugin_arg_opt (opt->arg);
#else
- error ("plugin support is disabled; configure with --enable-plugin");
+ error ("plugin support is disabled; configure with "
+ "%<--enable-plugin%>");
#endif
break;
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bootstrap: Fix bootstrap with --disable-plugin [PR104176]
2022-01-22 11:59 [PATCH] bootstrap: Fix bootstrap with --disable-plugin [PR104176] Jakub Jelinek
@ 2022-01-22 17:38 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-01-22 17:38 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Jeff Law, gcc-patches
> Am 22.01.2022 um 13:00 schrieb Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org>:
>
> Hi!
>
> With --disable-plugin, bootstrap fails on x86_64-linux or probably
> all other targets with:
> ../../gcc/opts-global.cc: In function ‘void handle_common_deferred_options()’:
> ../../gcc/opts-global.cc:420:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag]
> 420 | error ("plugin support is disabled; configure with --enable-plugin");
> | ^~~~~~~~~~~~~~~
> ../../gcc/opts-global.cc:428:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag]
> 428 | error ("plugin support is disabled; configure with --enable-plugin");
> | ^~~~~~~~~~~~~~~
>
> The following patch fixes that, bootstrapped on x86_64-linux with
> --disable-plugin --enable-languages=c,c++
> without the patch (where it failed as above) and with it (where it
> succeeded), ok for trunk
Ok.
Richard
> 2022-01-22 Jakub Jelinek <jakub@redhat.com>
>
> PR other/104176
> * opts-global.cc (handle_common_deferred_options): Quote
> --enable-plugin in diagnostics to avoid -Werror=format-diag.
>
> --- gcc/opts-global.cc.jj 2022-01-18 11:58:59.741979785 +0100
> +++ gcc/opts-global.cc 2022-01-22 02:18:39.116047945 +0100
> @@ -417,7 +417,8 @@ handle_common_deferred_options (void)
> #ifdef ENABLE_PLUGIN
> add_new_plugin (opt->arg);
> #else
> - error ("plugin support is disabled; configure with --enable-plugin");
> + error ("plugin support is disabled; configure with "
> + "%<--enable-plugin%>");
> #endif
> break;
>
> @@ -425,7 +426,8 @@ handle_common_deferred_options (void)
> #ifdef ENABLE_PLUGIN
> parse_plugin_arg_opt (opt->arg);
> #else
> - error ("plugin support is disabled; configure with --enable-plugin");
> + error ("plugin support is disabled; configure with "
> + "%<--enable-plugin%>");
> #endif
> break;
>
>
>
> Jakub
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-22 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 11:59 [PATCH] bootstrap: Fix bootstrap with --disable-plugin [PR104176] Jakub Jelinek
2022-01-22 17:38 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).