From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13535 invoked by alias); 16 Jul 2007 11:55:47 -0000 Received: (qmail 13517 invoked by uid 22791); 16 Jul 2007 11:55:47 -0000 X-Spam-Check-By: sourceware.org Received: from mail1.nsc.com (HELO mailgate1.nsc.com) (12.151.32.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 16 Jul 2007 11:55:37 +0000 X-WSS-ID: 0JL9T50-05-7BY-01 Received: from SCNTRDCSS5.nsc.com (unknown [192.168.7.17]) by mailgate1.nsc.com (Tumbleweed MailGate) with ESMTP id 60098380120DA for ; Mon, 16 Jul 2007 04:55:48 -0700 (PDT) Received: from 139.187.179.130 by SCNTRDCSS5.nsc.com with ESMTP (-Hi-); Mon, 16 Jul 2007 04:55:26 -0700 X-Server-Uuid: 8E4229DB-B86C-4032-82C7-2B351B449D4C Received: from [139.187.78.153] by scmh1.nsc.com with ESMTP; Mon, 16 Jul 2007 04:55:26 -0700 Message-ID: <469B5C21.7030604@nsc.com> Date: Mon, 16 Jul 2007 13:01:00 -0000 From: "Pompapathi V Gadad" User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: "'Rask Ingemann Lambertsen'" cc: "Pompapathi V Gadad" , gcc-patches@gcc.gnu.org Subject: Re: [Patch] New: CR16 port References: <000001c7c5c6$e81dc4d0$144efea9@gadadsystem1> <469B32A6.6090009@nsc.com> <20070716115108.GG5690@sygehus.dk> In-Reply-To: <20070716115108.GG5690@sygehus.dk> X-WSS-ID: 6A8583241E8293317-02-01 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg01428.txt.bz2 'Rask Ingemann Lambertsen' wrote: > On Mon, Jul 16, 2007 at 02:26:06PM +0530, Pompapathi V Gadad wrote: > > >> Index: doc/extend.texi >> =================================================================== >> --- doc/extend.texi (revision 126669) >> +++ doc/extend.texi (working copy) >> @@ -2100,11 +2100,10 @@ This attribute is ignored for R8C target >> >> @item interrupt >> @cindex interrupt handler functions >> -Use this attribute on the ARM, AVR, C4x, CRX, M32C, M32R/D, m68k, MS1, >> -and Xstormy16 ports to indicate that the specified function is an >> -interrupt handler. The compiler will generate function entry and exit >> -sequences suitable for use in an interrupt handler when this attribute >> -is present. >> +Use this attribute on the ARM, AVR, C4x, CR16, CRX, M32C, M32R/D, MS1, >> +and Xstormy16 ports to indicate that the specified function is an interrupt >> +handler. The compiler will generate function entry and exit sequences suitable >> +for use in an interrupt handler when this attribute is present. >> >> Note, interrupt handlers for the Blackfin, H8/300, H8/300H, H8S, and >> SH processors can be specified via the @code{interrupt_handler} attribute. >> > > You're still modifying the m68k documentation. > I am extremely sorry, I do not know how m68k changes has gone in to this patch. I will be careful now on. > >> Index: config/cr16/cr16.md >> > [...] > >> +(define_mode_attr tIsa [(QI "b") (HI "w") (SI "d") (SF "d")]) >> +(define_mode_attr tIsaLong [ (SI "d") (SF "d")]) >> +(define_mode_attr tIsaShort [(QI "b") (HI "w") ]) >> > > You should be able to use tIsa instead of tIsaLong and tIsaShort > everywhere. > > >> +(define_mode_attr lImmShort [(QI "4") (HI "4") ]) >> +(define_mode_attr lImmLong [ (SI "6") (SF "6")]) >> +(define_mode_attr lImmArith [(QI "4") (HI "4") (SI "6") (SF "6")]) >> > > And something similiar goes here. > > >> +;; Negation Instructions >> +; move 0,r sub x,r. More efficient than xor -1,x add 1,x >> +(define_expand "neg2" >> + [(set (match_operand:CR16IM 0 "register_operand" "") >> + (const_int 0)) >> + (parallel [(set (match_dup 0) >> + (minus:CR16IM (match_dup 0) >> + (match_operand:CR16IM 1 "register_operand" ""))) >> + (clobber (reg:CC CC_REGNUM))]) >> + ] >> + "" >> + "") >> > > You said you would delete this expander. Did it not work? > > I will make necessary changes and post the pacthes. Thanks a lot, Pompa