From: Diego Novillo <dnovillo@google.com>
To: Jan Hubicka <jh@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Reduce startup cost of compiler (patch 3)
Date: Tue, 24 Jul 2007 12:57:00 -0000 [thread overview]
Message-ID: <46A5DFBF.7040403@google.com> (raw)
In-Reply-To: <20070724050556.GD10270@kam.mff.cuni.cz>
On 7/24/07 1:05 AM, Jan Hubicka wrote:
> * caller-save.c: Include ggc.h, gt-caller-save.h
> (reg_save_code, reg_restore_code): Rename to ...
> (cached_reg_save_code, cached_reg_restore_code): ... those.
> (savepat, restpat, test_reg, test_mem, saveinsn, restinsn): New.
> (reg_save_code, reg_restore_code): New functions.
> (init_caller_save): Do not intialize
> reg_save_code/reg_restore_code tables.
> * Makeifle.in: (gt-caller-save.h): New.
OK with:
> + static int
> + reg_save_code (int reg, enum machine_mode mode)
Missing documentation.
> + static int
> + reg_restore_code (int reg, enum machine_mode mode)
> + {
Likewise.
> + if (cached_reg_restore_code[reg][mode])
> + return cached_reg_restore_code[reg][mode];
> + /* polute our cache. */
s/polute/pollute/
> --- 704,710 ----
> pat = gen_rtx_SET (VOIDmode,
> gen_rtx_REG (GET_MODE (mem),
> regno), mem);
> ! code = reg_restore_code(regno, GET_MODE (mem));
Space before '('.
> --- 776,782 ----
> pat = gen_rtx_SET (VOIDmode, mem,
> gen_rtx_REG (GET_MODE (mem),
> regno));
> ! code = reg_save_code(regno, GET_MODE (mem));
Likewise.
> @@ -2700,7 +2700,8 @@ postreload-gcse.o : postreload-gcse.c $(
> $(PARAMS_H) $(TIMEVAR_H) tree-pass.h $(REAL_H) $(DBGCNT_H)
> caller-save.o : caller-save.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) \
> $(FLAGS_H) $(REGS_H) hard-reg-set.h insn-config.h $(BASIC_BLOCK_H) $(FUNCTION_H) \
> - addresses.h $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H) $(DF_H)
> + addresses.h $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H) $(DF_H) \
> + gt-caller-save.h
ggc.h should also be included here.
next prev parent reply other threads:[~2007-07-24 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 6:51 Jan Hubicka
2007-07-24 12:57 ` Diego Novillo [this message]
2007-07-24 15:01 ` Daniel Jacobowitz
2007-07-24 15:09 ` Diego Novillo
2007-08-07 14:30 ` Rask Ingemann Lambertsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A5DFBF.7040403@google.com \
--to=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jh@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).