From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-200075-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6161 invoked by alias); 24 Jul 2007 11:17:30 -0000
Received: (qmail 6153 invoked by uid 22791); 24 Jul 2007 11:17:29 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jul 2007 11:17:27 +0000
Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) 	by smtp-out.google.com with ESMTP id l6OBHKhn028616; 	Tue, 24 Jul 2007 04:17:20 -0700
Received: from frodo.local ([172.26.101.157]) 	by zps35.corp.google.com with ESMTP id l6OBHEhe026001; 	Tue, 24 Jul 2007 04:17:14 -0700
Message-ID: <46A5DFBF.7040403@google.com>
Date: Tue, 24 Jul 2007 12:57:00 -0000
From: Diego Novillo <dnovillo@google.com>
User-Agent: Thunderbird 2.0.0.5 (Macintosh/20070716)
MIME-Version: 1.0
To: Jan Hubicka <jh@suse.cz>
CC: gcc-patches@gcc.gnu.org
Subject: Re: Reduce startup cost of compiler (patch 3)
References: <20070724050556.GD10270@kam.mff.cuni.cz>
In-Reply-To: <20070724050556.GD10270@kam.mff.cuni.cz>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-07/txt/msg01723.txt.bz2

On 7/24/07 1:05 AM, Jan Hubicka wrote:

> 	* caller-save.c: Include ggc.h, gt-caller-save.h
> 	(reg_save_code, reg_restore_code): Rename to ...
> 	(cached_reg_save_code, cached_reg_restore_code): ... those.
> 	(savepat, restpat, test_reg, test_mem, saveinsn, restinsn): New.
> 	(reg_save_code, reg_restore_code): New functions.
> 	(init_caller_save): Do not intialize
> 	reg_save_code/reg_restore_code tables.
> 	* Makeifle.in: (gt-caller-save.h): New.

OK with:

> + static int
> + reg_save_code (int reg, enum machine_mode mode)

Missing documentation.

> + static int
> + reg_restore_code (int reg, enum machine_mode mode)
> + {

Likewise.

> +   if (cached_reg_restore_code[reg][mode])
> +      return cached_reg_restore_code[reg][mode];
> +   /* polute our cache.  */

s/polute/pollute/

> --- 704,710 ----
>     pat = gen_rtx_SET (VOIDmode,
>   		     gen_rtx_REG (GET_MODE (mem),
>   				  regno), mem);
> !   code = reg_restore_code(regno, GET_MODE (mem));

Space before '('.

> --- 776,782 ----
>     pat = gen_rtx_SET (VOIDmode, mem,
>   		     gen_rtx_REG (GET_MODE (mem),
>   				  regno));
> !   code = reg_save_code(regno, GET_MODE (mem));

Likewise.

> @@ -2700,7 +2700,8 @@ postreload-gcse.o : postreload-gcse.c $(
>     $(PARAMS_H) $(TIMEVAR_H) tree-pass.h $(REAL_H) $(DBGCNT_H)
>  caller-save.o : caller-save.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) \
>     $(FLAGS_H) $(REGS_H) hard-reg-set.h insn-config.h $(BASIC_BLOCK_H) $(FUNCTION_H) \
> -   addresses.h $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H) $(DF_H)
> +   addresses.h $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H) $(DF_H) \
> +   gt-caller-save.h

ggc.h should also be included here.