From: Kenneth Zadeck <zadeck@naturalbridge.com>
To: gcc-bugzilla@gcc.gnu.org, gcc-patches <gcc-patches@gcc.gnu.org>,
"Park, Seongbae" <seongbae.park@gmail.com>,
Richard Sandiford <rsandifo@nildram.co.uk>,
"Bonzini, Paolo" <bonzini@gnu.org>
Subject: Re: [Bug middle-end/32749] [4.3 regression]: gfortran.dg/auto_array_1.f90
Date: Fri, 27 Jul 2007 17:39:00 -0000 [thread overview]
Message-ID: <46AA2B8E.1080900@naturalbridge.com> (raw)
In-Reply-To: <20070726115131.30046.qmail@sourceware.org>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
This patch rearranges the updating of the local dataflow info when
building reg_dead notes. The need for this was that processing was not
correctly handled for clobbers that occurred within conditional call
insns. A rare case but one that at least happens on the ia-64.
This patch not only fixes the regressions listed in pr32749, but also
fixes the gfortran.dg/matmul_3.f90 on the ia-64 regressions.
This patch was bootstrapped and regression tested yesterday on x86-64
and ia-64 and was again bootstrapped this morning on x86-64 (just to
make sure there were no interactions with richard sandiford's fixes to
closely related code that was just committed.)
Committed as revision 126987.
Kenny
2007-07-26 Kenneth Zadeck <zadeck@naturalbridge.com>
PR middle-end/32749
* df-problems.c (df_create_unused_note): Removed do_not_gen parm
and the updating of the live and do_not_gen sets.
(df_note_bb_compute): Added updating of live and do_not_gen sets
for regular defs so that the case of clobber inside conditional
call is processed correctly.
[-- Attachment #2: notes5.diff --]
[-- Type: text/x-patch, Size: 3175 bytes --]
Index: df-problems.c
===================================================================
--- df-problems.c (revision 126979)
+++ df-problems.c (working copy)
@@ -3868,13 +3868,12 @@ df_set_dead_notes_for_mw (rtx insn, rtx
}
-/* Create a REG_UNUSED note if necessary for DEF in INSN updating LIVE
- and DO_NOT_GEN. Do not generate notes for registers in artificial
- uses. */
+/* Create a REG_UNUSED note if necessary for DEF in INSN updating
+ LIVE. Do not generate notes for registers in ARTIFICIAL_USES. */
static rtx
df_create_unused_note (rtx insn, rtx old, struct df_ref *def,
- bitmap live, bitmap do_not_gen, bitmap artificial_uses)
+ bitmap live, bitmap artificial_uses)
{
unsigned int dregno = DF_REF_REGNO (def);
@@ -3899,12 +3898,6 @@ df_create_unused_note (rtx insn, rtx old
#endif
}
- if (!(DF_REF_FLAGS (def) & (DF_REF_MUST_CLOBBER + DF_REF_MAY_CLOBBER)))
- bitmap_set_bit (do_not_gen, dregno);
-
- /* Kill this register if it is not a subreg store or conditional store. */
- if (!(DF_REF_FLAGS (def) & (DF_REF_PARTIAL | DF_REF_CONDITIONAL)))
- bitmap_clear_bit (live, dregno);
return old;
}
@@ -3915,7 +3908,7 @@ df_create_unused_note (rtx insn, rtx old
static void
df_note_bb_compute (unsigned int bb_index,
- bitmap live, bitmap do_not_gen, bitmap artificial_uses)
+ bitmap live, bitmap do_not_gen, bitmap artificial_uses)
{
basic_block bb = BASIC_BLOCK (bb_index);
rtx insn;
@@ -4012,17 +4005,17 @@ df_note_bb_compute (unsigned int bb_inde
for (def_rec = DF_INSN_UID_DEFS (uid); *def_rec; def_rec++)
{
struct df_ref *def = *def_rec;
- if (!(DF_REF_FLAGS (def) & (DF_REF_MUST_CLOBBER | DF_REF_MAY_CLOBBER)))
- old_unused_notes
- = df_create_unused_note (insn, old_unused_notes,
- def, live, do_not_gen,
- artificial_uses);
-
- /* However a may or must clobber still needs to kill the
- reg so that REG_DEAD notes are later placed
- appropriately. */
- else
- bitmap_clear_bit (live, DF_REF_REGNO (def));
+ unsigned int dregno = DF_REF_REGNO (def);
+ if (!DF_REF_FLAGS_IS_SET (def, DF_REF_MUST_CLOBBER | DF_REF_MAY_CLOBBER))
+ {
+ old_unused_notes
+ = df_create_unused_note (insn, old_unused_notes,
+ def, live, artificial_uses);
+ bitmap_set_bit (do_not_gen, dregno);
+ }
+
+ if (!DF_REF_FLAGS_IS_SET (def, DF_REF_PARTIAL | DF_REF_CONDITIONAL))
+ bitmap_clear_bit (live, dregno);
}
}
else
@@ -4043,10 +4036,16 @@ df_note_bb_compute (unsigned int bb_inde
for (def_rec = DF_INSN_UID_DEFS (uid); *def_rec; def_rec++)
{
struct df_ref *def = *def_rec;
+ unsigned int dregno = DF_REF_REGNO (def);
old_unused_notes
= df_create_unused_note (insn, old_unused_notes,
- def, live, do_not_gen,
- artificial_uses);
+ def, live, artificial_uses);
+
+ if (!DF_REF_FLAGS_IS_SET (def, DF_REF_MUST_CLOBBER | DF_REF_MAY_CLOBBER))
+ bitmap_set_bit (do_not_gen, dregno);
+
+ if (!DF_REF_FLAGS_IS_SET (def, DF_REF_PARTIAL | DF_REF_CONDITIONAL))
+ bitmap_clear_bit (live, dregno);
}
}
prev parent reply other threads:[~2007-07-27 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-32749-682@http.gcc.gnu.org/bugzilla/>
[not found] ` <20070716232625.9422.qmail@sourceware.org>
2007-07-26 12:06 ` Kenneth Zadeck
2007-07-26 17:35 ` Seongbae Park (박성배, 朴成培)
2007-07-26 17:55 ` Kenneth Zadeck
2007-07-26 18:47 ` Seongbae Park (박성배, 朴成培)
[not found] ` <20070726115131.30046.qmail@sourceware.org>
2007-07-27 17:39 ` Kenneth Zadeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AA2B8E.1080900@naturalbridge.com \
--to=zadeck@naturalbridge.com \
--cc=bonzini@gnu.org \
--cc=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rsandifo@nildram.co.uk \
--cc=seongbae.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).