From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15977 invoked by alias); 30 Jul 2007 11:19:13 -0000 Received: (qmail 15968 invoked by uid 22791); 30 Jul 2007 11:19:12 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Jul 2007 11:17:58 +0000 Received: (qmail 15935 invoked from network); 30 Jul 2007 11:17:56 -0000 Received: from unknown (HELO bullfrog.localdomain) (sandra@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Jul 2007 11:17:56 -0000 Message-ID: <46ADC92E.1000506@codesourcery.com> Date: Mon, 30 Jul 2007 12:53:00 -0000 From: Sandra Loosemore User-Agent: Thunderbird 2.0.0.5 (X11/20070716) MIME-Version: 1.0 To: David Daney CC: GCC Patches , Richard Sandiford Subject: [PATCH] Re: MIPS support for __builtin_flush_icache() breaks -mips16 References: <46AD4861.1090807@codesourcery.com> <46AD5781.7080900@avtrex.com> In-Reply-To: <46AD5781.7080900@avtrex.com> Content-Type: multipart/mixed; boundary="------------080905060202060102070206" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg02104.txt.bz2 This is a multi-part message in MIME format. --------------080905060202060102070206 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 948 David Daney wrote: > Sandra Loosemore wrote: >> Now that mainline HEAD is buildable on MIPS again, I've observed that >> this patch >> >> http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01026.html >> >> causes failures with -mips16, e.g. on >> gcc.c-torture/compile/20050122-2.c. > > That makes sense to me. However I am have never tested mips16. > > There are several options: > > 1) Tell me how you configured and tested. I think one of my boards will > do mips16 so I could probably test it if I hacked around a little. > > 2) You could prepare a patch and test with that change as it seems that > you are able to do mips16 testing. Well, the answer to 1) is that I'm building mipsisa32r2-elfoabi and testing using the GDB simulator. But, if you're not set up to do this, 2) is probably easier all around, so I built and tested the attached patch overnight, and verified that it fixes the MIPS16 regressions. OK to commit? -Sandra --------------080905060202060102070206 Content-Type: text/x-log; name="synci.log" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="synci.log" Content-length: 128 2007-07-30 Sandra Loosemore gcc/ * config/mips/mips.h (ISA_HAS_SYNCI): Add !TARGET_MIPS16 test. --------------080905060202060102070206 Content-Type: text/x-patch; name="synci.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="synci.patch" Content-length: 596 Index: gcc/config/mips/mips.h =================================================================== *** gcc/config/mips/mips.h (revision 127056) --- gcc/config/mips/mips.h (working copy) *************** extern const struct mips_rtx_cost_data * *** 819,825 **** || TARGET_MIPS5500) /* ISA includes synci, jr.hb and jalr.hb. */ ! #define ISA_HAS_SYNCI ISA_MIPS32R2 /* Add -G xx support. */ --- 819,825 ---- || TARGET_MIPS5500) /* ISA includes synci, jr.hb and jalr.hb. */ ! #define ISA_HAS_SYNCI (ISA_MIPS32R2 && !TARGET_MIPS16) /* Add -G xx support. */ --------------080905060202060102070206--