From: Kenneth Zadeck <zadeck@naturalbridge.com>
To: tromey@redhat.com
Cc: Mark Mitchell <mark@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>, "Hubicha\,
Jan" <jh@suse.cz>
Subject: Re: [lto] PATCH COMMITTED Re: potiential problems with parm decls.
Date: Wed, 01 Aug 2007 22:36:00 -0000 [thread overview]
Message-ID: <46B10AE9.5070408@naturalbridge.com> (raw)
In-Reply-To: <m3fy329b30.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "KZ" == Kenneth Zadeck <zadeck@naturalbridge.com> writes:
>>>>>>
>
> KZ> + /* Output the argument array. */
> KZ> + LTO_DEBUG_INDENT_TOKEN ("decl_arguments")
>
> I find it a little strange to see function-like macro invocations with
> no terminating ";".
>
> In addition to looking strange, this upsets Emacs; it may be odd but
> GNU-style indentation is partially defined as "whatever makes Emacs do
> the right thing".
>
> Tom
>
I do not disagree with you. the problem is that i am not really that
sophisticated a user of c macros and i do not know how to make it work
if you put the semicolons in.
The problem is that if you turn off the lto debugging, these macros
become the empty string and you are left with a hanging semicolon.
if you or anyone else has a better way to do this, i am happy to change it.
I am a little tired of emacs moving the next stmt around also.
Kenny
next prev parent reply other threads:[~2007-08-01 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 14:16 Kenneth Zadeck
2007-08-01 17:23 ` Mark Mitchell
2007-08-01 17:34 ` Kenneth Zadeck
2007-08-02 0:43 ` Mark Mitchell
2007-08-02 1:10 ` Kenneth Zadeck
2007-08-02 2:50 ` Mark Mitchell
2007-08-01 20:44 ` [lto] PATCH COMMITTED " Kenneth Zadeck
2007-08-01 22:12 ` Tom Tromey
2007-08-01 22:36 ` Kenneth Zadeck [this message]
2007-08-02 1:06 ` [lto] PATCH COMMITTED to fix missing semicolons Kenneth Zadeck
2007-08-02 1:16 ` David Daney
2007-08-02 1:49 ` Andrew Pinski
2007-08-02 16:42 ` Kenneth Zadeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B10AE9.5070408@naturalbridge.com \
--to=zadeck@naturalbridge.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jh@suse.cz \
--cc=mark@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).