public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@avtrex.com>
To: Kenneth Zadeck <zadeck@naturalbridge.com>
Cc: tromey@redhat.com, Mark Mitchell <mark@codesourcery.com>,
		gcc-patches <gcc-patches@gcc.gnu.org>,
	"Hubicha, Jan" <jh@suse.cz>
Subject: Re: [lto] PATCH COMMITTED to fix missing semicolons.
Date: Thu, 02 Aug 2007 01:16:00 -0000	[thread overview]
Message-ID: <46B1304E.4000405@avtrex.com> (raw)
In-Reply-To: <46B12E1D.2010708@naturalbridge.com>

Kenneth Zadeck wrote:
> Tom Tromey wrote:
>>>>>>> "KZ" == Kenneth Zadeck <zadeck@naturalbridge.com> writes:
>>>>>>>             
>> KZ> +  /* Output the argument array.  */
>> KZ> +  LTO_DEBUG_INDENT_TOKEN ("decl_arguments")
>>
>> I find it a little strange to see function-like macro invocations with
>> no terminating ";".
>>
>> In addition to looking strange, this upsets Emacs; it may be odd but
>> GNU-style indentation is partially defined as "whatever makes Emacs do
>> the right thing".
>>
>> Tom
>>   
> I figured out how to do this.
> 
> committed as revision 127145.
> 
>  #else
> -#define LTO_DEBUG_INDENT(tag)
> -#define LTO_DEBUG_INDENT_TOKEN(value)
> -#define LTO_DEBUG_INTEGER(tag,high,low)
> -#define LTO_DEBUG_STRING(value,len)
> -#define LTO_DEBUG_TOKEN(value)
> -#define LTO_DEBUG_UNDENT()
> -#define LTO_DEBUG_WIDE(tag,value)
> +#define LTO_DEBUG_INDENT(tag) useless_function ()

Perhaps:

#define LTO_DEBUG_INDENT(tag) do {} while(0)

David Daney

  reply	other threads:[~2007-08-02  1:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 14:16 potiential problems with parm decls Kenneth Zadeck
2007-08-01 17:23 ` Mark Mitchell
2007-08-01 17:34   ` Kenneth Zadeck
2007-08-02  0:43     ` Mark Mitchell
2007-08-02  1:10       ` Kenneth Zadeck
2007-08-02  2:50         ` Mark Mitchell
2007-08-01 20:44   ` [lto] PATCH COMMITTED " Kenneth Zadeck
2007-08-01 22:12     ` Tom Tromey
2007-08-01 22:36       ` Kenneth Zadeck
2007-08-02  1:06       ` [lto] PATCH COMMITTED to fix missing semicolons Kenneth Zadeck
2007-08-02  1:16         ` David Daney [this message]
2007-08-02  1:49           ` Andrew Pinski
2007-08-02 16:42             ` Kenneth Zadeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B1304E.4000405@avtrex.com \
    --to=ddaney@avtrex.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jh@suse.cz \
    --cc=mark@codesourcery.com \
    --cc=tromey@redhat.com \
    --cc=zadeck@naturalbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).