From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4137 invoked by alias); 2 Aug 2007 19:26:16 -0000 Received: (qmail 4118 invoked by uid 22791); 2 Aug 2007 19:26:15 -0000 X-Spam-Check-By: sourceware.org Received: from exsmtp01.agrinet.ch (HELO exsmtp01.agrinet.ch) (81.221.254.200) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Aug 2007 19:26:10 +0000 Received: from smtp.messaging.ch ([10.50.250.214]) by exsmtp01.agrinet.ch with Microsoft SMTPSVC(6.0.3790.1830); Thu, 2 Aug 2007 21:26:06 +0200 Received: from wolfram.andreas.nets ([84.73.68.225]) by smtp.messaging.ch with id X7SW1X0014rcz700000000; Thu, 02 Aug 2007 21:26:35 +0200 X-IMP: RBL SORBS: 0.10,RBL SPAMCOP: 0.00,RBL SBL+XBL: 0.00,URL RHS: 0.00,URL SURBL: 0.00 Message-ID: <46B22FC9.8030707@pop.agri.ch> Date: Thu, 02 Aug 2007 19:26:00 -0000 From: Andreas Tobler User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: David Daney CC: GCJ-patches , GCC Patches , andreast@gcc.gnu.org Subject: Re: [Patch] libffi: Fix broken return_ul.c test. References: <46B04209.3000509@avtrex.com> In-Reply-To: <46B04209.3000509@avtrex.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00142.txt.bz2 David Daney wrote: > The return_ul.c test is failing for mips64 n32 ABI. The problem is that > the return value location was too small and was overflowing into > adjacent memory. > > According to the libffi README, return values must be at least as large > as ffi_arg, so that is what I used. > > Tested on x86_64-pc-linux-gnu and mips64-linux-gnu. > > OK to commit? > > 2007-08-01 David Daney > > * testsuite/libffi.call/return_ul.c (main): Define return type as > ffi_arg. Use proper printf conversion specifier. > Looks ok, at least to my understanding. Thanks, Andreas