From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13012 invoked by alias); 4 Aug 2007 18:08:58 -0000 Received: (qmail 12868 invoked by uid 22791); 4 Aug 2007 18:08:57 -0000 X-Spam-Check-By: sourceware.org Received: from vms048pub.verizon.net (HELO vms048pub.verizon.net) (206.46.252.48) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 04 Aug 2007 18:08:55 +0000 Received: from [192.168.1.2] ([71.120.231.21]) by vms048.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JM900E1HH25UG71@vms048.mailsrvcs.net>; Sat, 04 Aug 2007 13:08:30 -0500 (CDT) Date: Sat, 04 Aug 2007 18:08:00 -0000 From: Jerry DeLisle Subject: Re: [Patch, Fortran] PR32987 - Allow TAB in FORMAT statements as extension and warn with -std=f* In-reply-to: <46B4B951.2050501@net-b.de> To: Tobias Burnus Cc: "'fortran@gcc.gnu.org'" , gcc-patches Message-id: <46B4BFB2.3080909@verizon.net> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: <46B4B951.2050501@net-b.de> User-Agent: Thunderbird 1.5.0.12 (X11/20070719) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00247.txt.bz2 Tobias Burnus wrote: > :ADDPATCH fortran: > > In FORMAT statements, standard Fortran only allow tabs ('\t') in string > literals. However, all other compiler I checked allow it: ifort, g95, > NAG f95, sunf95, openf95. Except of ifort (with the option "-stand f95") > none of the compilers even print a compile-time warning. > > gfortran currently accepts tabs quietly at compile time, but gives a > run-time error. > > Given that all other compilers allow it, I would suggest to allow it as > well - and follow ifort by giving a warning with -std=f95/f2003. > (Actually, I have chosen to give a gfc_warning instead of an gfc_error > to save myself from several levels of error propagation :-) > > Note, however, that Steve disagrees (see PR for full quote): > > "A tab is not a legal substitution for a space character." [...] > "Here's a patch that permits gfortran to accept your INVALID code." > (His patch is the same as the libgfortran part of my patch; he continues > then:) > "[...] I will activity oppose application of this patch by others." > > Reasoning by Steve: > > "gfortran has been around for a long time now and this is the first > report of the tab-in-format runtime error. gfortran should complain > loudly that the code is invalid." > > > While I still think accepting it with a compile-time warning is enough, > I strongly believe that there should be in any case a COMPILE-TIME > diagnostic whatever we decide about accepting or rejecting it at run time. > I think everyone is in agreement that a compile time diagnostic should be given: I think the default behavior, without -std=XXX, should give the warning at compile. I think that for -std=f95 or -std=f2003, an error should be given at compile time. At runtime, quiet acceptance for default, there is no runtime for -std= Regards. Jerry