From: Mark Mitchell <mark@codesourcery.com>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][C++/Java] Get rid of the walk_subtrees langhook
Date: Mon, 06 Aug 2007 00:24:00 -0000 [thread overview]
Message-ID: <46B66A3E.8050403@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707261627310.6492@s68.fhfr.qr>
Richard Guenther wrote:
> 2007-07-26 Richard Guenther <rguenther@suse.de>
>
> * tree.c (WALK_SUBTREE): Call walk_tree_1.
> (walk_type_fields): Take lh parameter.
This is OK, with one change: I don't think "walk_tree_lh" is a mnemonic
name for the type of the supplemental walker function. Perhaps
"walk_subtree_fn", like "walk_tree_fn", is better. In any case, the
typedef should have a comment saying what the varios parameters are.
With those changes, the patch is fine, thanks!
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2007-08-06 0:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 14:32 Richard Guenther
2007-07-26 16:35 ` Andrew Haley
2007-08-06 0:24 ` Mark Mitchell [this message]
2007-08-20 11:18 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B66A3E.8050403@codesourcery.com \
--to=mark@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).