From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27047 invoked by alias); 6 Aug 2007 00:24:43 -0000 Received: (qmail 26816 invoked by uid 22791); 6 Aug 2007 00:24:42 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 00:24:40 +0000 Received: (qmail 32193 invoked from network); 6 Aug 2007 00:24:38 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Aug 2007 00:24:38 -0000 Message-ID: <46B66A3E.8050403@codesourcery.com> Date: Mon, 06 Aug 2007 00:24:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Richard Guenther CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][C++/Java] Get rid of the walk_subtrees langhook References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00285.txt.bz2 Richard Guenther wrote: > 2007-07-26 Richard Guenther > > * tree.c (WALK_SUBTREE): Call walk_tree_1. > (walk_type_fields): Take lh parameter. This is OK, with one change: I don't think "walk_tree_lh" is a mnemonic name for the type of the supplemental walker function. Perhaps "walk_subtree_fn", like "walk_tree_fn", is better. In any case, the typedef should have a comment saying what the varios parameters are. With those changes, the patch is fine, thanks! -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713