From: Mark Mitchell <mark@codesourcery.com>
To: Laurynas Biveinis <laurynas.biveinis@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: Remove an RTL usage in the C++ front end
Date: Mon, 06 Aug 2007 03:34:00 -0000 [thread overview]
Message-ID: <46B696D0.4030900@codesourcery.com> (raw)
In-Reply-To: <20070713034508.GA2111@google.com>
Dan Hipschman wrote:
> 2007-06-12 Dan Hipschman <dsh@google.com>
>
> * cp/method.c (use_thunk): Use get_name instead of DECL_RTL to
> access function name.
>
> Index: cp/method.c
> ===================================================================
> --- cp/method.c (revision 126593)
> +++ cp/method.c (working copy)
> @@ -430,7 +430,7 @@ use_thunk (tree thunk_fndecl, bool emit_
> current_function_decl = thunk_fndecl;
> DECL_RESULT (thunk_fndecl)
> = build_decl (RESULT_DECL, 0, integer_type_node);
> - fnname = XSTR (XEXP (DECL_RTL (thunk_fndecl), 0), 0);
> + fnname = get_name (thunk_fndecl);
Why use get_name here? I'd actually prefer that we use name
IDENTIFIER_POINTER (DECL_NAME (thunk_fndecl)); we don't want the
recursive ADDR_EXPR behavior in get_name, do we?
OK with that change.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2007-08-06 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 3:43 Dan Hipschman
2007-07-13 3:45 ` Laurynas Biveinis
2007-07-13 5:52 ` Dan Hipschman
2007-08-06 3:34 ` Mark Mitchell [this message]
2007-08-06 22:10 ` Dan Hipschman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B696D0.4030900@codesourcery.com \
--to=mark@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=laurynas.biveinis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).