From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30213 invoked by alias); 6 Aug 2007 03:34:53 -0000 Received: (qmail 30159 invoked by uid 22791); 6 Aug 2007 03:34:52 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 03:34:51 +0000 Received: (qmail 7276 invoked from network); 6 Aug 2007 03:34:49 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Aug 2007 03:34:49 -0000 Message-ID: <46B696D0.4030900@codesourcery.com> Date: Mon, 06 Aug 2007 03:34:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Laurynas Biveinis , gcc-patches@gcc.gnu.org Subject: Re: Remove an RTL usage in the C++ front end References: <20070713032718.GA18363@google.com> <20070713034508.GA2111@google.com> In-Reply-To: <20070713034508.GA2111@google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00298.txt.bz2 Dan Hipschman wrote: > 2007-06-12 Dan Hipschman > > * cp/method.c (use_thunk): Use get_name instead of DECL_RTL to > access function name. > > Index: cp/method.c > =================================================================== > --- cp/method.c (revision 126593) > +++ cp/method.c (working copy) > @@ -430,7 +430,7 @@ use_thunk (tree thunk_fndecl, bool emit_ > current_function_decl = thunk_fndecl; > DECL_RESULT (thunk_fndecl) > = build_decl (RESULT_DECL, 0, integer_type_node); > - fnname = XSTR (XEXP (DECL_RTL (thunk_fndecl), 0), 0); > + fnname = get_name (thunk_fndecl); Why use get_name here? I'd actually prefer that we use name IDENTIFIER_POINTER (DECL_NAME (thunk_fndecl)); we don't want the recursive ADDR_EXPR behavior in get_name, do we? OK with that change. -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713