From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18156 invoked by alias); 6 Aug 2007 03:50:41 -0000 Received: (qmail 18073 invoked by uid 22791); 6 Aug 2007 03:50:40 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 03:50:38 +0000 Received: (qmail 7676 invoked from network); 6 Aug 2007 03:50:36 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Aug 2007 03:50:36 -0000 Message-ID: <46B69A83.4070301@codesourcery.com> Date: Mon, 06 Aug 2007 03:50:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: "Fu, Chao-Ying" CC: gcc-patches@gcc.gnu.org, "Thekkath, Radhika" , "Stephens, Nigel" Subject: Re: [ping][patch] Fixed-point patch 2/10 References: <3CB54817FDF733459B230DD27C690CEC03EE8EF2@Exchange.mips.com> In-Reply-To: <3CB54817FDF733459B230DD27C690CEC03EE8EF2@Exchange.mips.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00300.txt.bz2 Fu, Chao-Ying wrote: > gcc/ChangeLog > 2007-08-01 Chao-ying Fu > > * fixed-value.h: New file. > * fixed-value.c: New file. > * Makefile.in (OBJS-common): Add fixed-value.o. > (fixed-value.o): New rule. > (GTFILES): Add fixed-value.h. > * double-int.c (double_int_scmp): Use casts of unsigned HOST_WIDE_INT > to compare a.low and b.low. > * gengtype.c (main): Handle FIXED_VALUE_TYPE type as scalar typedef. This is OK -- except that I do not understand the change to double_int_scmp. That function explicitly assumes that the double int is signed, as opposed to double_int_ucmp, which assumes that it is unsigned. Please explain. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713