From: Paolo Bonzini <bonzini@gnu.org>
To: Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFC,PATCH] Provide get_attr functions with alternative parameter
Date: Mon, 06 Aug 2007 15:47:00 -0000 [thread overview]
Message-ID: <46B7428E.5070902@gnu.org> (raw)
In-Reply-To: <20070806152927.GA3999@blc4eb430604175.ibm.com>
> The attached patch provides getter functions with an additional
> argument specifying the number of the alternative for which the
> attribute value should be returned. In order to get the old behaviour
> the functions need to be invoked with -1 as alternative number. Inline
> wrappers with the old function names are provided in order to keep
> backwards compatibility.
Interesting! Is there a reason (in the patch you're working on) why the
inline wrappers couldn't just do
extract_constrain_insn_cached (insn);
return get_alt_attr_blah_blah (insn, which_alternative);
instead of supporting the special alternative number -1 in
get_alt_attr_blah_blah? (I can see the reason could be code bloat, or
GCC deciding not to inline get_attr_blah_blah, but I thought I'd just ask).
Paolo
next prev parent reply other threads:[~2007-08-06 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 15:30 Andreas Krebbel
2007-08-06 15:47 ` Paolo Bonzini [this message]
2007-08-07 11:45 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B7428E.5070902@gnu.org \
--to=bonzini@gnu.org \
--cc=Andreas.Krebbel@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).