public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: "\"Seongbae Park (박성배, 朴成培)\"" <seongbae.park@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	  Nathan Sidwell <nathan@codesourcery.com>
Subject: Re: [PATCH] Wrong line number for the closing brace of template functions
Date: Mon, 06 Aug 2007 18:11:00 -0000	[thread overview]
Message-ID: <46B7644E.9080808@codesourcery.com> (raw)
In-Reply-To: <ab3a61990708061036gbcb1a62pcdb81954e5d5c5de@mail.gmail.com>

Seongbae Park (박성배, 朴成培) wrote:

> gcc/testsuite/ChangeLog:
> 
> 2007-08-06  Seongbae Park <seongbae.park@gmail.com>
> 
>         * g++.dg/gcov/gcov-5.C: New test.

> gcc/cp/ChangeLog:
> 
> 2007-08-06  Seongbae Park <seongbae.park@gmail.com>
> 
>         * pt.c (instantiate_decl): Set input_location
>         for the function end.

This patch is OK, after Nathan finishes reviewing the other one.

However, this comment:

+      /* Make sure the current input_location
+         is set correctly to the end of the function
+	 - this makes finish_function to set
+	 function_end_locus of this specialization correctly. */

could be written better as:

/* Set the current input_location to the end of the function so
   that finish_function knows where we are.  */

The "makes x to set y" construct is not grammatical.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

  reply	other threads:[~2007-08-06 18:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 17:36 Seongbae Park (박성배, 朴成培)
2007-08-06 18:11 ` Mark Mitchell [this message]
2007-08-06 18:47   ` Dave Korn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B7644E.9080808@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nathan@codesourcery.com \
    --cc=seongbae.park@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).