From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25741 invoked by alias); 6 Aug 2007 18:11:40 -0000 Received: (qmail 25648 invoked by uid 22791); 6 Aug 2007 18:11:39 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 18:11:37 +0000 Received: (qmail 22775 invoked from network); 6 Aug 2007 18:11:36 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Aug 2007 18:11:36 -0000 Message-ID: <46B7644E.9080808@codesourcery.com> Date: Mon, 06 Aug 2007 18:11:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: =?UTF-8?B?IlNlb25nYmFlIFBhcmsgKOuwleyEseuwsCwg5py05oiQ5Z+5KSI=?= CC: gcc-patches , Nathan Sidwell Subject: Re: [PATCH] Wrong line number for the closing brace of template functions References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00372.txt.bz2 Seongbae Park (박성배, 朴成培) wrote: > gcc/testsuite/ChangeLog: > > 2007-08-06 Seongbae Park > > * g++.dg/gcov/gcov-5.C: New test. > gcc/cp/ChangeLog: > > 2007-08-06 Seongbae Park > > * pt.c (instantiate_decl): Set input_location > for the function end. This patch is OK, after Nathan finishes reviewing the other one. However, this comment: + /* Make sure the current input_location + is set correctly to the end of the function + - this makes finish_function to set + function_end_locus of this specialization correctly. */ could be written better as: /* Set the current input_location to the end of the function so that finish_function knows where we are. */ The "makes x to set y" construct is not grammatical. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713