Re: [patch] Remove redundant calls to copy_virtual_operands

[Diego Novillo <dnovillo@google.com>]

On 8/7/07 8:08 AM, Ira Rosen wrote:

>       * tree-vect-transform.c (vectorizable_store): Remove call to
>       copy_virtual_operands() and call mark_symbols_for_renaming() for
>       the created vector store.
>       (vect_setup_realignment): Don't call copy_virtual_operands() and
>       update_vuses_to_preheader().
>       (vectorizable_load): Don't call copy_virtual_operands().
>       (update_vuses_to_preheader): Remove.

Well, it's certainly safe to do this.  However, you may be marking more
symbols for renaming than strictly necessary.  Have you compared compile
times?  If you are marking more symbols for renaming than before, you
are probably increasing the time needed to update the SSA form.

It may certainly make it easier to maintain, but if the compile times
are a problem, I would suggest going with what you had before.  Though
I'd be willing to bet that this won't really affect compile times all
that much.