From: David Daney <ddaney@avtrex.com>
To: GCJ-patches <java-patches@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: andreast@gcc.gnu.org
Subject: [Patch] libffi testsuite: Correct some type specifiers.
Date: Tue, 07 Aug 2007 16:27:00 -0000 [thread overview]
Message-ID: <46B89D13.50708@avtrex.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
Whilst hacking things up to get MIPS64 working better in libffi, I came
across several test cases where structure elements were declared as type
'int' but the libffi type specifier identified them as uint32.
This patch corrects some (but probably not all) of these incongruities.
Tested on x86_64-pc-linux-gnu and Mips64-linux.
OK to commit?
2007-08-07 David Daney <ddaney@avtrex.com>
* testsuite/libffi.call/nested_struct.c (main): Use correct type
specifiers in structure specification.
* testsuite/libffi.call/cls_24byte.c (main): Ditto.
* testsuite/libffi.call/cls_12byte.c (main): Ditto.
* testsuite/libffi.call/cls_16byte.c (main): Ditto.
[-- Attachment #2: ffitypes.diff --]
[-- Type: text/x-patch, Size: 2521 bytes --]
Index: testsuite/libffi.call/nested_struct.c
===================================================================
--- testsuite/libffi.call/nested_struct.c (revision 127010)
+++ testsuite/libffi.call/nested_struct.c (working copy)
@@ -108,10 +108,10 @@ int main (void)
cls_struct_fields[0] = &ffi_type_double;
cls_struct_fields[1] = &ffi_type_float;
- cls_struct_fields[2] = &ffi_type_uint32;
+ cls_struct_fields[2] = &ffi_type_sint32;
cls_struct_fields[3] = NULL;
- cls_struct_fields1[0] = &ffi_type_uint32;
+ cls_struct_fields1[0] = &ffi_type_sint32;
cls_struct_fields1[1] = &ffi_type_double;
cls_struct_fields1[2] = &ffi_type_float;
cls_struct_fields1[3] = NULL;
Index: testsuite/libffi.call/cls_24byte.c
===================================================================
--- testsuite/libffi.call/cls_24byte.c (revision 127010)
+++ testsuite/libffi.call/cls_24byte.c (working copy)
@@ -82,7 +82,7 @@ int main (void)
cls_struct_fields[0] = &ffi_type_double;
cls_struct_fields[1] = &ffi_type_double;
- cls_struct_fields[2] = &ffi_type_uint32;
+ cls_struct_fields[2] = &ffi_type_sint32;
cls_struct_fields[3] = &ffi_type_float;
cls_struct_fields[4] = NULL;
Index: testsuite/libffi.call/cls_12byte.c
===================================================================
--- testsuite/libffi.call/cls_12byte.c (revision 127010)
+++ testsuite/libffi.call/cls_12byte.c (working copy)
@@ -66,9 +66,9 @@ int main (void)
struct cls_struct_12byte j_dbl = { 1, 5, 3 };
struct cls_struct_12byte res_dbl;
- cls_struct_fields[0] = &ffi_type_uint32;
- cls_struct_fields[1] = &ffi_type_uint32;
- cls_struct_fields[2] = &ffi_type_uint32;
+ cls_struct_fields[0] = &ffi_type_sint32;
+ cls_struct_fields[1] = &ffi_type_sint32;
+ cls_struct_fields[2] = &ffi_type_sint32;
cls_struct_fields[3] = NULL;
dbl_arg_types[0] = &cls_struct_type;
Index: testsuite/libffi.call/cls_16byte.c
===================================================================
--- testsuite/libffi.call/cls_16byte.c (revision 127010)
+++ testsuite/libffi.call/cls_16byte.c (working copy)
@@ -67,9 +67,9 @@ int main (void)
struct cls_struct_16byte j_dbl = { 1, 9.0, 3 };
struct cls_struct_16byte res_dbl;
- cls_struct_fields[0] = &ffi_type_uint32;
+ cls_struct_fields[0] = &ffi_type_sint32;
cls_struct_fields[1] = &ffi_type_double;
- cls_struct_fields[2] = &ffi_type_uint32;
+ cls_struct_fields[2] = &ffi_type_sint32;
cls_struct_fields[3] = NULL;
dbl_arg_types[0] = &cls_struct_type;
next reply other threads:[~2007-08-07 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 16:27 David Daney [this message]
2007-08-07 17:04 ` Tom Tromey
2007-08-07 17:18 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B89D13.50708@avtrex.com \
--to=ddaney@avtrex.com \
--cc=andreast@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).