From: Diego Novillo <dnovillo@google.com>
To: Christopher Matthews <chrismatthews@google.com>
Cc: gcc-patches@gcc.gnu.org, Aldy Hernandez <aldyh@redhat.com>
Subject: Re: [tuples] Fixed inconsistent iterator interface
Date: Tue, 07 Aug 2007 22:46:00 -0000 [thread overview]
Message-ID: <46B8F62F.9010303@google.com> (raw)
In-Reply-To: <5794c4c80708071533o3b1ae68bncd38d219e702afc0@mail.gmail.com>
On 8/7/07 6:33 PM, Christopher Matthews wrote:
> -static inline gimple_stmt_iterator
> +static inline gimple_stmt_iterator*
space before '*'.
> gsi_start (gimple_seq seq)
> {
> - gimple_stmt_iterator i;
> + gimple_stmt_iterator* i = ggc_alloc_cleared (sizeof (gimple_stmt_iterator));
^^^^^^^^^^^^^^^^^^^^^^^
gimple_stmt_iterator *i
> - gimple_stmt_iterator i;
> + gimple_stmt_iterator* ittr;
Why the new name? Was 'i' clashing with some other local?
> -extern void verify_gimple_1 (tree);
> +extern void verify_gimple_1 (gimple_seq);
This is for your next patch, me thinks.
> -/* Verify the GIMPLE statements inside the statement list STMTS. */
> +/* Verify the GIMPLE statements inside the sequence STMTS. */
> void
> -verify_gimple_1 (tree stmts)
> +verify_gimple_1 (gimple_seq stmts)
Likewise.
OK with those changes.
next prev parent reply other threads:[~2007-08-07 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 22:33 Christopher Matthews
2007-08-07 22:46 ` Diego Novillo [this message]
2007-08-07 22:50 ` Christopher Matthews
2007-08-07 22:56 ` Christopher Matthews
2007-08-07 23:07 ` Christopher Matthews
2007-08-07 23:11 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B8F62F.9010303@google.com \
--to=dnovillo@google.com \
--cc=aldyh@redhat.com \
--cc=chrismatthews@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).