From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27058 invoked by alias); 8 Aug 2007 20:51:56 -0000 Received: (qmail 26927 invoked by uid 22791); 8 Aug 2007 20:51:54 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Aug 2007 20:51:45 +0000 Received: (qmail 6928 invoked from network); 8 Aug 2007 20:51:43 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Aug 2007 20:51:43 -0000 Message-ID: <46BA2CD7.6080009@codesourcery.com> Date: Wed, 08 Aug 2007 20:51:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Andrew Pinski , Mark Mitchell , Sandra Loosemore , GCC Patches , richard@codesourcery.com Subject: Re: PATCH: ffs/ctz expansions using clz References: <46B13576.2040800@codesourcery.com> <87wswebggj.fsf@firetop.home> <46BA154C.6030607@codesourcery.com> <20070808204808.GA21368@caradoc.them.org> In-Reply-To: <20070808204808.GA21368@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00543.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Aug 08, 2007 at 01:41:30PM -0700, Andrew Pinski wrote: >>> All right. Let's do the following for CLZ_DEFINED_VALUE_DEFINED_AT_ZERO: > >> #define CLZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ > > Aren't those different macros? Only because I misspelled mine. Andrew's right; I misinterpreted what the rs6000/rs6000.h macro is doing. So, Sandra, you will also need to modify that implementation of the macro to return 1, in the same way that, for example, ARM does. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713