public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Nick Clifton <nickc@redhat.com>,
	echristo@apple.com,         gcc-patches@gcc.gnu.org,
	richard@codesourcery.com
Subject: Re: RFA/RFC: GCC has an incorrect length for the ldc1 instruction
Date: Fri, 10 Aug 2007 07:15:00 -0000	[thread overview]
Message-ID: <46BC103B.4090007@redhat.com> (raw)
In-Reply-To: <87hcnb8ybn.fsf@firetop.home>

Hi Richard,

> I think instead that mips_fetch_insns should try to prove that
> the move does not need to be split, and tell mips_address_insns
> about it.  Does the patch below work for you?

Yes.

> gcc/
> 	* config/mips/mips-protos.h (mips_address_insns): Add a boolean
> 	argument.
> 	(mips_fetch_insns): Delete in favor of...
> 	(mips_load_store_insns): ...this new function.
> 	* config/mips/mips.c (mips_address_insns): Add a boolean argument
> 	to say whether multiword moves _might_ be split.
> 	(mips_fetch_insns): Delete in favor of...
> 	(mips_load_store_insns): ...this new function.
> 	(mips_rtx_costs): Update the call to mips_address_insns.
> 	(mips_address_cost): Likewise.
> 	* config/mips/mips.md (length): Use mips_load_store_insns instead
> 	of mips_fetch_insns.
> 	* config/mips/constraints.md (R): Use mips_address_insns rather
> 	than mips_fetch_insns.  Assume that the move never needs to be split.

Are you going to apply this version of the patch, or may I do it on your behalf ?

Cheers
   Nick

  parent reply	other threads:[~2007-08-10  7:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07  8:07 Nick Clifton
2007-08-07  9:54 ` Richard Sandiford
2007-08-07 15:03   ` Nick Clifton
2007-08-10  7:15   ` Nick Clifton [this message]
2007-08-10  7:58     ` Richard Sandiford
2007-08-10 15:41       ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BC103B.4090007@redhat.com \
    --to=nickc@redhat.com \
    --cc=echristo@apple.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).