From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-201222-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 14710 invoked by alias); 10 Aug 2007 09:48:29 -0000
Received: (qmail 14653 invoked by uid 22791); 10 Aug 2007 09:48:27 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.lu.unisi.ch (HELO mail.lu.unisi.ch) (195.176.178.40)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Aug 2007 09:48:23 +0000
Received: from burning-guy.rett.polimi.it ([131.175.65.145]) by mail.lu.unisi.ch over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); 	 Fri, 10 Aug 2007 11:48:42 +0200
Message-ID: <46BC321A.7060007@lu.unisi.ch>
Date: Fri, 10 Aug 2007 09:48:00 -0000
From: Paolo Bonzini <paolo.bonzini@lu.unisi.ch>
Reply-To:  bonzini@gnu.org
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
MIME-Version: 1.0
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Add a __nowarn__ keyword
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-08/txt/msg00656.txt.bz2

[sorry for breaking the thread]

> +  if (strcmp (kind_string, "push") == 0)
> +    {
> +      stack = (diagnostic_stack_entry_t *) xmalloc (sizeof (diagnostic_stack_entry_t));
> +      stack->previous = diagnostic_stack;
> +      stack->state = diagnostic_save_classifications (global_dc);
> +      diagnostic_stack = stack;
> +      return;
> +    }

> If yes, is the "push" necessary?  Can we make it implicit?

We could have something like this:

     if (memcmp (kind_string, "push", 4) == 0
         && (kind_string[4] == '\0' || ISSPACE (kind_string[4])))
       {
         ...
         diagnostic_stack = stack;
         kind_string += 4;
         while (ISSPACE (*kind_string))
           kind_string++;
         if (*kind_string == '\0')
           return;
       }

which allows both

#pragma GCC diagnostics push

and

#pragma GCC diagnostics push ignore "-Wcast-qual"

Paolo