From: Sandra Loosemore <sandra@codesourcery.com>
To: David Ung <davidu@mips.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
richard@codesourcery.com
Subject: Re: PATCH: MIPS 74K load/store scheduling tweak (take 2)
Date: Fri, 10 Aug 2007 16:37:00 -0000 [thread overview]
Message-ID: <46BC93F0.7010909@codesourcery.com> (raw)
In-Reply-To: <874pj7ct31.fsf@firetop.home>
Richard Sandiford wrote:
> Sandra Loosemore <sandra@codesourcery.com> writes:
>> + /* Implement TARGET_SCHED_INIT. */
>> +
>> + static void
>> + mips_sched_init (FILE *file ATTRIBUTE_UNUSED, int verbose ATTRIBUTE_UNUSED,
>> + int max_ready ATTRIBUTE_UNUSED)
>> + {
>> + if (!reload_completed && TUNE_MACC_CHAINS)
>> + mips_macc_chains_last_hilo = 0;
>> + if (reload_completed && TUNE_MIPS4130 && !TARGET_VR4130_ALIGN)
>> + vr4130_last_insn = 0;
>> + if (TUNE_74K)
>> + mips_74k_agen_init (NULL_RTX);
>> +
>> + }
>
> Excess blank line before "}". Might as well do the initialisations
> unconditinally; it's one less thing to keep in sync.
>
> OK with that change, thanks. No need to retest; if it compiles,
> it's fine.
OK, committed. :-)
-Sandra
prev parent reply other threads:[~2007-08-10 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 0:13 Sandra Loosemore
2007-08-04 7:35 ` Richard Sandiford
2007-08-06 16:21 ` David Ung
2007-08-06 16:40 ` Richard Sandiford
2007-08-06 17:19 ` David Ung
2007-08-06 17:53 ` Richard Sandiford
2007-08-07 10:43 ` David Ung
2007-08-10 15:17 ` Sandra Loosemore
2007-08-10 15:22 ` Richard Sandiford
2007-08-10 16:37 ` Sandra Loosemore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BC93F0.7010909@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=davidu@mips.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).