Re: [Patch] libffi: Add MIPS64 support.

[David Daney <ddaney@avtrex.com>]

Maciej W. Rozycki wrote:
> David,
> 
>  While integrating into 4.1.2 I had a brief look over your patch again 
> over the weekend and I have got two minor points:
> 
> 1. You use "unsigned" rather than "unsigned int", which makes your code 
>    look a little bit too K&Rish.

Prior art in src/mips/ffi.c has it both ways.  The patch very much 
carries on this tradition.

> 
> 2. Given the coverage FFI_MIPS_N32 should probably be renamed to 
>    FFI_MIPS_NEWABI as it is now somewhat confusing.

On the principle that a patch should only make changes necessary to 
implement its main goal, I left this as it was.

I would not oppose patches that address either of these issues.

> 
> And last but not least, with your changes there is now no difference 
> between Linux and IRIX anymore, so it may be worth unifying the MIPS 
> target like the others; it seems to be the only oddball.
> 
> 2007-08-13  Maciej W. Rozycki  <macro@linux-mips.org>
> 
> 	* Makefile.am: Unify MIPS_IRIX and MIPS_LINUX into MIPS.
> 	* configure.ac: Likewise.
> 	* Makefile.in: Regenerate.
> 	* configure: Regenerate.
> 
>  OK to apply?

I cannot approve the patch, but if it was tested on both Irix and 
mips64-linux I think it is a good idea.

Thanks,
David Daney