From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6914 invoked by alias); 13 Aug 2007 18:19:30 -0000 Received: (qmail 6886 invoked by uid 22791); 13 Aug 2007 18:19:29 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.144) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 18:19:14 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id E2683309DB4; Mon, 13 Aug 2007 18:19:24 +0000 (UTC) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [67.116.42.147]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP; Mon, 13 Aug 2007 18:19:24 +0000 (UTC) Received: from [192.168.7.26] ([192.168.7.26]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 13 Aug 2007 11:19:09 -0700 Message-ID: <46C0A09D.1060309@avtrex.com> Date: Mon, 13 Aug 2007 18:19:00 -0000 From: David Daney User-Agent: Thunderbird 1.5.0.12 (X11/20070719) MIME-Version: 1.0 To: "Maciej W. Rozycki" Cc: Richard Sandiford , GCJ-patches , GCC Patches Subject: Re: [Patch] libffi: Add MIPS64 support. References: <46BA9F13.2090003@avtrex.com> <87r6mddo7z.fsf@firetop.home> <46BB3754.30105@avtrex.com> <87wsw4d7h4.fsf@firetop.home> <46BB4F54.108@avtrex.com> <46BC8300.4080407@avtrex.com> <46BD4BDE.8030407@avtrex.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00814.txt.bz2 Maciej W. Rozycki wrote: > David, > > While integrating into 4.1.2 I had a brief look over your patch again > over the weekend and I have got two minor points: > > 1. You use "unsigned" rather than "unsigned int", which makes your code > look a little bit too K&Rish. Prior art in src/mips/ffi.c has it both ways. The patch very much carries on this tradition. > > 2. Given the coverage FFI_MIPS_N32 should probably be renamed to > FFI_MIPS_NEWABI as it is now somewhat confusing. On the principle that a patch should only make changes necessary to implement its main goal, I left this as it was. I would not oppose patches that address either of these issues. > > And last but not least, with your changes there is now no difference > between Linux and IRIX anymore, so it may be worth unifying the MIPS > target like the others; it seems to be the only oddball. > > 2007-08-13 Maciej W. Rozycki > > * Makefile.am: Unify MIPS_IRIX and MIPS_LINUX into MIPS. > * configure.ac: Likewise. > * Makefile.in: Regenerate. > * configure: Regenerate. > > OK to apply? I cannot approve the patch, but if it was tested on both Irix and mips64-linux I think it is a good idea. Thanks, David Daney