From: Diego Novillo <dnovillo@google.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Add printing functions to tree-affine.c
Date: Tue, 14 Aug 2007 15:54:00 -0000 [thread overview]
Message-ID: <46C1CFFE.9050207@google.com> (raw)
In-Reply-To: <de8d50360708111222p305c86f1g5f2efb2c4a1d4a30@mail.gmail.com>
On 8/11/07 1:22 PM, Andrew Pinski wrote:
> +/* Debugging functions. */
> +void print_aff (FILE *file, aff_tree *val);
> +void debug_aff (aff_tree *val);
No need to specify argument names here.
> +
> +void
> +print_aff (FILE *file, aff_tree *val)
Needs comment.
> +void
> +debug_aff (aff_tree *val)
Likewise.
> + fprintf (file, "\n elments = {\n");
s/elments/elements/
OK with those changes.
prev parent reply other threads:[~2007-08-14 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 19:22 Andrew Pinski
2007-08-14 15:54 ` Diego Novillo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C1CFFE.9050207@google.com \
--to=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).