public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Maxim Kuvyrkov <maxim@codesourcery.com>
To: Richard Sandiford <richard@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH]: Fix mips breakage after fdl-pool patch
Date: Wed, 15 Aug 2007 13:09:00 -0000	[thread overview]
Message-ID: <46C2FADB.7050707@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hello Richard,

I broke mips backend with my last scheduler patch that changed interface 
to scheduler dependency analyzer (sched-deps.c).

This obvious patch fixes things by changing mips backend to use new 
interface.

I audited other targets for the same error and they appear to be fine.

Ok for trunk?


Thanks,

Maxim

[-- Attachment #2: fdl-pool-mips.ChangeLog --]
[-- Type: text/plain, Size: 145 bytes --]

2007-08-15  Maxim Kuvyrkov  <maxim@codesourcery.com>

	* config/mips/mips.c (vr4130_swap_insns_p): Use new interface to
	scheduler dependencies.

[-- Attachment #3: fdl-pool-mips.patch --]
[-- Type: text/x-patch, Size: 1165 bytes --]

Index: config/mips/mips.c
===================================================================
--- config/mips/mips.c	(revision 127511)
+++ config/mips/mips.c	(working copy)
@@ -10930,7 +10930,8 @@ vr4130_true_reg_dependence_p (rtx insn)
 static bool
 vr4130_swap_insns_p (rtx insn1, rtx insn2)
 {
-  dep_link_t dep;
+  sd_iterator_def sd_it;
+  dep_t dep;
 
   /* Check for the following case:
 
@@ -10940,11 +10941,11 @@ vr4130_swap_insns_p (rtx insn1, rtx insn
 
      If INSN1 is the last instruction blocking X, it would better to
      choose (INSN1, X) over (INSN2, INSN1).  */
-  FOR_EACH_DEP_LINK (dep, INSN_FORW_DEPS (insn1))
-    if (DEP_LINK_KIND (dep) == REG_DEP_ANTI
-	&& INSN_PRIORITY (DEP_LINK_CON (dep)) > INSN_PRIORITY (insn2)
-	&& recog_memoized (DEP_LINK_CON (dep)) >= 0
-	&& get_attr_vr4130_class (DEP_LINK_CON (dep)) == VR4130_CLASS_ALU)
+  FOR_EACH_DEP (insn1, SD_LIST_FORW, sd_it, dep)
+    if (DEP_TYPE (dep) == REG_DEP_ANTI
+	&& INSN_PRIORITY (DEP_CON (dep)) > INSN_PRIORITY (insn2)
+	&& recog_memoized (DEP_CON (dep)) >= 0
+	&& get_attr_vr4130_class (DEP_CON (dep)) == VR4130_CLASS_ALU)
       return false;
 
   if (vr4130_last_insn != 0

             reply	other threads:[~2007-08-15 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-15 13:09 Maxim Kuvyrkov [this message]
2007-08-15 13:27 ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C2FADB.7050707@codesourcery.com \
    --to=maxim@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).