public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: Mark Mitchell <mark@codesourcery.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
	  GCC Patches <gcc-patches@gcc.gnu.org>,
	 Nigel Stephens <nigel@mips.com>, Guy Morrogh <guym@mips.com>,
	  David Ung <davidu@mips.com>,  Thiemo Seufer <ths@mips.com>,
	  Richard Sandiford <richard@codesourcery.com>
Subject: Re: PATCH: fine-tuning for can_store_by_pieces
Date: Fri, 17 Aug 2007 13:24:00 -0000	[thread overview]
Message-ID: <46C5A0FF.7080601@codesourcery.com> (raw)
In-Reply-To: <46C528F0.5040101@codesourcery.com>

Mark Mitchell wrote:

> In the various places where you clone the macro, I think you should just
>  do:
> 
> #define SET_BY_PIECES_P(SIZE, ALIGN) STORE_BY_PIECES_P(SIZE, ALIGN)
> 
> In fact, if you do that in expr.c, under #ifndef SET_BY_PIECES_P, I
> think you can void changing the other backends at all, as you'll
> automatically pick up their STORE_BY_PIECES_P definitions.

I previously considered that idea, but that means that just defining SET_RATIO 
to be different than MOVE_RATIO won't do anything useful.  Making the default 
definition of SET_BY_PIECES_P use SET_RATIO and making the latter default to 
MOVE_RATIO seemed to be the best combination of avoiding breaking current 
backend code while making it easy to tweak in the future.  If I do it your way, 
there's no point in having SET_RATIO in the target-independent code at all, 
because nothing would refer to it.

-Sandra

  reply	other threads:[~2007-08-17 13:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-15 17:15 Sandra Loosemore
2007-08-15 17:22 ` Andrew Pinski
2007-08-15 18:32   ` Sandra Loosemore
2007-08-15 19:53     ` Nigel Stephens
2007-08-15 19:58   ` Sandra Loosemore
2007-08-17  4:50   ` Mark Mitchell
2007-08-17 13:24     ` Sandra Loosemore [this message]
2007-08-17 18:55       ` Mark Mitchell
2007-08-16  8:34 ` Richard Sandiford
2007-08-16 19:41   ` Sandra Loosemore
2007-08-19  0:03   ` Sandra Loosemore
2007-08-20  8:22     ` Richard Sandiford
2007-08-20 23:38       ` Sandra Loosemore
2007-08-21  8:21         ` Richard Sandiford
2007-08-21 10:34           ` Nigel Stephens
2007-08-21 11:53             ` Richard Sandiford
2007-08-21 12:14               ` Nigel Stephens
2007-08-21 12:35                 ` Richard Sandiford
2007-08-21 13:54           ` Sandra Loosemore
2007-08-21 14:22             ` Richard Sandiford
2007-08-21 20:39               ` Sandra Loosemore
2007-08-21 20:56                 ` Richard Sandiford
2007-08-23 14:35                   ` Sandra Loosemore
2007-08-23 14:44                     ` Richard Sandiford
2007-08-25  5:35                       ` [committed] " Sandra Loosemore
2007-08-25  9:18                         ` Jakub Jelinek
2007-08-25  9:58                           ` Jakub Jelinek
2007-08-25 14:30                           ` gcc.c-torture/execute/20030221-1.c regressed with "fine-tuning for can_store_by_pieces" Hans-Peter Nilsson
2007-08-25 14:40                           ` [committed] Re: PATCH: fine-tuning for can_store_by_pieces Sandra Loosemore
2007-08-24 22:06                     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C5A0FF.7080601@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=davidu@mips.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guym@mips.com \
    --cc=mark@codesourcery.com \
    --cc=nigel@mips.com \
    --cc=pinskia@gmail.com \
    --cc=richard@codesourcery.com \
    --cc=ths@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).