From: Tobias Burnus <burnus@net-b.de>
To: "Christopher D. Rickett" <crickett@lanl.gov>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: PING Re: [PATCH,fortran]: proposed fix for PR 33020
Date: Wed, 22 Aug 2007 20:43:00 -0000 [thread overview]
Message-ID: <46CC9FF2.5060201@net-b.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0708221411240.28758@lennox.lanl.gov>
Christopher D. Rickett wrote:
> PING
Well, FX had two questions, which I think remained unanswered:
>> the attached patch fixes PR 33020. currently, the kind of the SHAPE
>> parameter to c_f_pointer is set once the actual is seen. however,
>> this can prevent shape arguments of different kinds being used for
>> different calls within the same namespace. the SHAPE parameter
>> should not be set because it needs to allow any valid integer kind.
>
> Then why also remove the type, as follows?
>
>> - /* Give the optional SHAPE formal arg a type now that we've done our
>> - initial checking against the actual. */
>> - if (sym->intmod_sym_id == ISOCBINDING_F_POINTER)
>> - sym->formal->next->next->sym->ts.type = BT_INTEGER;
>
> I can understand that it needs to not have a kind, but it has to be
> an integer, right? With your patch, do you still correctly diagnose if
> someone tries to use a REAL array as shape?
>
> If you answer to that question, it's OK to commit.
Tobias
next prev parent reply other threads:[~2007-08-22 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 21:42 Christopher D. Rickett
2007-08-09 23:04 ` FX Coudert
2007-08-22 20:21 ` PING " Christopher D. Rickett
2007-08-22 20:43 ` Tobias Burnus [this message]
2007-08-22 21:16 ` Christopher D. Rickett
2007-08-22 21:53 ` Tobias Burnus
2007-08-22 21:56 ` Christopher D. Rickett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CC9FF2.5060201@net-b.de \
--to=burnus@net-b.de \
--cc=crickett@lanl.gov \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).